New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671345 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

evtest does not show INPUT_PROP_DIRECT and INPUT_PROP_POINTER values

Reported by charliemooney@chromium.org, Dec 5 2016

Issue description

Currently we're using evtest version 1.29 for ChromeOS, but that version doesn't display these two values that're relied on by Chrome to determine the purpose of a touch device (screen or pad).  It'll be useful to update evtest to a more modern version that includes this functionality.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a5c4039b5cf5536dbe5b0c31c4a6a4b402e8f8c4

commit a5c4039b5cf5536dbe5b0c31c4a6a4b402e8f8c4
Author: Charlie Mooney <charliemooney@chromium.org>
Date: Mon Dec 05 20:51:34 2016

Update evtest to version 1.31

This patch updated evtest to version 1.31.  This version includes
some extra code that prints out the values for INPUT_PROP_DIRECT and
INPUT_PROP_POINTER when it's displaying the evdev device's properties
at start.  These properties were invisible before, but are instrumental
in the way that Chrome decides which touch devices are touchpads and
which are touchscreens.  Therefore, adding them to this test tool will
make it easier to debug any issues that arise from mis-set values in
these two parameters in touch devices.

Note, there are a few changes to the ebuild that seem random.  The
new ebuild changes were copied from Gentoo here:
https://gitweb.gentoo.org/repo/gentoo.git/tree/app-misc/evtest/evtest-1.31.ebuild
It is the ebuild for 1.31 suggested on there and fixes some naming
issues with the newest mirrors tarball files.

BUG= chromium:671345 
TEST=emerged and tested on a Chromebook -- the new version built
correctly and was functional on the device I tested it on.  Not only
showing the existing functionality but also reporting the new properties
as well.

Change-Id: Id1746376fe54e97c22356b1691fcbace1719fc27
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/416500
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a5c4039b5cf5536dbe5b0c31c4a6a4b402e8f8c4/app-misc/evtest/Manifest
[add] https://crrev.com/a5c4039b5cf5536dbe5b0c31c4a6a4b402e8f8c4/app-misc/evtest/evtest-1.31-r1.ebuild
[rename] https://crrev.com/a5c4039b5cf5536dbe5b0c31c4a6a4b402e8f8c4/app-misc/evtest/evtest-1.31.ebuild
[delete] https://crrev.com/a756fc4091200a5566451392e7ba1de19d630906/app-misc/evtest/evtest-1.29-r1.ebuild

Status: Fixed (was: Started)

Comment 3 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 4 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment