New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 671338 link

Starred by 2 users
Status: Fixed
Owner:
█ kozyatinskiy@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

[REGRESSION] DevTools: debugger sidebar is not shown automatically

Project Member Reported by lushnikov@chromium.org, Dec 5 2016 
Chrome Version       : 57.0.2943.0

What steps will reproduce the problem?
1. Open Sources Panel
2. Hide debugger sidebar 
3. Hit "pause"

What is the expected result?
Execution paused, the debugger sidebar is shown

What happens instead of that?
Execution is paused, but the debugger sidebar is NOT shown.
What is worse, the "show debugger" button is disabled.


This is a regression issue caused by https://codereview.chromium.org/2552553002/
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2283e4077950ece67ce86491eb026c4f57b34bf1

commit 2283e4077950ece67ce86491eb026c4f57b34bf1
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Dec 06 03:16:57 2016

[DevTools] reveal debugger sidebar on pause

BUG= chromium:671338 
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2549363002
Cr-Commit-Position: refs/heads/master@{#436506}

[modify] https://crrev.com/2283e4077950ece67ce86491eb026c4f57b34bf1/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Comment 2 by kozyatinskiy@chromium.org, Dec 6 2016

Labels: Merge-Request-56
Status: Fixed (was: Assigned)

Comment 3 by dimu@chromium.org, Dec 7 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 7 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a46c027eaa6b22ae5a1d41266eb0ea4dd702898

commit 6a46c027eaa6b22ae5a1d41266eb0ea4dd702898
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Dec 07 22:44:46 2016

[DevTools] reveal debugger sidebar on pause

BUG= chromium:671338 
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2549363002
Cr-Commit-Position: refs/heads/master@{#436506}
(cherry picked from commit 2283e4077950ece67ce86491eb026c4f57b34bf1)

Review URL: https://codereview.chromium.org/2557513009 .

Cr-Commit-Position: refs/branch-heads/2924@{#394}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/6a46c027eaa6b22ae5a1d41266eb0ea4dd702898/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Comment 5 by sc00335...@techmahindra.com, Dec 8 2016 

Checked the issue on 56.0.2924.21 beta and is working fine. i.e;the debugger sidebar is seen after hitting F8 to pause.

Attaching video for reference.
Issue 671338.ogv
1.3 MB View Download

Comment 6 by ajha@chromium.org, Dec 8 2016

Labels: TE-Verified-56.0.2924.21 TE-Verified-M56
Adding verified label as per C#5.
►

Sign in to add a comment