New issue
Advanced search Search tips

Issue 671334 link

Starred by 1 user
Status: Fixed
Owner:
ryansturm@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move LoFi/LitePages to previews blacklist

Project Member Reported by ryansturm@chromium.org, Dec 5 2016 
Currently, LoFi and LitePages use their own opt out logic which looks at past sessions and the current session to determine whether a user should be shown LoFi/LitePages.

This decision should be moved to the PreviewsBlackList and shared with other preview types (e.g. Offline Previews), so there is not a disparate experience for users who are shown different types of previews.

Comment 1 by bengr@chromium.org, Feb 9 2017 

We will want to roll this out as an experiment.

Comment 2 by ryansturm@chromium.org, Feb 22 2017

Labels: -M-56 -Pri-3 M-58 Pri-2

Comment 3 by bengr@chromium.org, Mar 29 2017

Labels: -M-58 M-60
Project Member

Comment 4 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee

commit ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee
Author: ryansturm <ryansturm@chromium.org>
Date: Thu May 11 06:34:43 2017

Use the Previews Black List for server previews

This introduces a field trial to allow Flywheel server previews to use
the PreviewsBlackList to make decisions about whether to allow a
preview. The 3x3 rule that LoFi/WebLite currently use will still be
respected for legacy opted out users, but it will no longer be written
to while in the field trial.

BUG= 671334 

Review-Url: https://codereview.chromium.org/2864333003
Cr-Commit-Position: refs/heads/master@{#470845}

[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/components/data_reduction_proxy/DEPS
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/components/data_reduction_proxy/core/browser/BUILD.gn
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/ef62bd2a4181d1bd3e0e2e17d66d8f8e717377ee/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

Comment 5 by ryansturm@chromium.org, May 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment