We can 'alias' offset-rotate to offset-rotation, by adding cases for CSSPropertyOffsetRotate, and sharing storage with CSSPropertyOffsetRotation in ComputedStyle. Spec discussion: https://github.com/w3c/fxtf-drafts/issues/70 Design Doc: https://docs.google.com/document/d/1AHSyz3_Qu8hZK5czcQdfucVanoxpsUkBbzY16ti4_NY/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af51f3582ab7798d8a58628c6975f7c08df8c8a2 commit af51f3582ab7798d8a58628c6975f7c08df8c8a2 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Dec 07 02:09:02 2016 CSS Motion Path: Support offset-rotate in addition to offset-rotation offset-rotation is being renamed to offset-rotate, but we will already have shipped offset-rotation. We 'alias' offset-rotate to offset-rotation, sharing storage in ComputedStyle. Spec discussion: https://github.com/w3c/fxtf-drafts/issues/70 Design Docs: https://goo.gl/XFvGR8 https://docs.google.com/document/d/1AHSyz3_Qu8hZK5czcQdfucVanoxpsUkBbzY16ti4_NY/edit?usp=sharing BUG= 671333 Review-Url: https://codereview.chromium.org/2555543002 Cr-Commit-Position: refs/heads/master@{#436835} [add] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/animations/composition/offset-rotate-composition.html [add] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/animations/interpolation/offset-rotate-interpolation.html [add] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/animations/responsive/offset-rotate-responsive.html [add] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/css3/motion-path/offset-rotate.html [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/platform/android/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/platform/android/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/platform/android/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/platform/android/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/platform/android/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/core/css/CSSProperties.in [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/core/frame/UseCounter.cpp [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/core/style/ComputedStyle.h [modify] https://crrev.com/af51f3582ab7798d8a58628c6975f7c08df8c8a2/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
Your change meets the bar and is auto-approved for M56 (branch: 2924)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e35b7e19bbb795da9ab17c9e27e58c02656823fe commit e35b7e19bbb795da9ab17c9e27e58c02656823fe Author: Eric Willigers <ericwilligers@chromium.org> Date: Thu Dec 08 02:06:43 2016 CSS Motion Path: Support offset-rotate in addition to offset-rotation offset-rotation is being renamed to offset-rotate, but we will already have shipped offset-rotation. We 'alias' offset-rotate to offset-rotation, sharing storage in ComputedStyle. Spec discussion: https://github.com/w3c/fxtf-drafts/issues/70 Design Docs: https://goo.gl/XFvGR8 https://docs.google.com/document/d/1AHSyz3_Qu8hZK5czcQdfucVanoxpsUkBbzY16ti4_NY/edit?usp=sharing BUG= 671333 Review-Url: https://codereview.chromium.org/2555543002 Cr-Commit-Position: refs/heads/master@{#436835} (cherry picked from commit af51f3582ab7798d8a58628c6975f7c08df8c8a2) Review URL: https://codereview.chromium.org/2559073002 . Cr-Commit-Position: refs/branch-heads/2924@{#399} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [add] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/animations/composition/offset-rotate-composition.html [add] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/animations/interpolation/offset-rotate-interpolation.html [add] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/animations/responsive/offset-rotate-responsive.html [add] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/css3/motion-path/offset-rotate.html [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/platform/android/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/platform/android/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/platform/android/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/platform/android/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/platform/android/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/core/css/CSSProperties.in [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/core/frame/UseCounter.cpp [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/core/style/ComputedStyle.h [modify] https://crrev.com/e35b7e19bbb795da9ab17c9e27e58c02656823fe/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
Comment 1 by ericwilligers@chromium.org
, Dec 5 2016