New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671300 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-XR
Proj-XR-VR

Blocked on:
issue 671349



Sign in to add a comment

Create runtime flag to enable VR Shell

Project Member Reported by sko...@chromium.org, Dec 5 2016

Issue description

Currently VR shell functionality is enabled via a build flag.  It should be enabled via a runtime (chrome://) flag, which should also be controllable via Finch experiment in the future.
 
Labels: M-57
Components: UI>Browser>VR

Comment 3 by bshe@chromium.org, Dec 5 2016

Status: WontFix (was: Assigned)
I have created a tri-state flag in the past. The thing I am not sure about if that if all our vr_shell features are hided behind the flag that we have. There might be cases that missed due to oversight. But the flag itself is already landed. So mark this as wont fix.
What's the name of the flag?

Comment 5 by bshe@chromium.org, Dec 5 2016

enable-vr-shell. You should be able to find it in the about://flag page on Chrome on Android. And I believe finch experimental already implemented based on the flag name. @amp?

Comment 6 by amp@chromium.org, Dec 5 2016

Yes, the change that added this was https://codereview.chromium.org/2470583002

I haven't marked issue 655199 as fixed yet as we haven't added the server side config (because it was blocked on the build flag being enabled for release builds).

Comment 7 by amp@chromium.org, Dec 5 2016

Filed  issue 671349  to track the build flag.
Status: Assigned (was: WontFix)
I see it listed in Beta, but it doesn't show in Canary or Dev.  Re-opening so we can fix that.

Comment 9 by amp@chromium.org, Dec 5 2016

The runtime flag is there, it is only visible when the build flag is enabled.

What you are seeing in beta is the old Vr Shell flag (the new one uses 'Chrome VR' in about://flags).

We can keep this open until the build is enabled, but there isn't any more work to do on it that I can see.

Comment 10 by amp@chromium.org, Dec 7 2016

Blockedon: 671349

Comment 11 by amp@chromium.org, Dec 9 2016

Status: Fixed (was: Assigned)
Build flag is in.  The about://flags visible changes should show up in the next canary release.

Sign in to add a comment