Create runtime flag to enable VR Shell |
||||||
Issue descriptionCurrently VR shell functionality is enabled via a build flag. It should be enabled via a runtime (chrome://) flag, which should also be controllable via Finch experiment in the future.
,
Dec 5 2016
,
Dec 5 2016
I have created a tri-state flag in the past. The thing I am not sure about if that if all our vr_shell features are hided behind the flag that we have. There might be cases that missed due to oversight. But the flag itself is already landed. So mark this as wont fix.
,
Dec 5 2016
What's the name of the flag?
,
Dec 5 2016
enable-vr-shell. You should be able to find it in the about://flag page on Chrome on Android. And I believe finch experimental already implemented based on the flag name. @amp?
,
Dec 5 2016
Yes, the change that added this was https://codereview.chromium.org/2470583002 I haven't marked issue 655199 as fixed yet as we haven't added the server side config (because it was blocked on the build flag being enabled for release builds).
,
Dec 5 2016
Filed issue 671349 to track the build flag.
,
Dec 5 2016
I see it listed in Beta, but it doesn't show in Canary or Dev. Re-opening so we can fix that.
,
Dec 5 2016
The runtime flag is there, it is only visible when the build flag is enabled. What you are seeing in beta is the old Vr Shell flag (the new one uses 'Chrome VR' in about://flags). We can keep this open until the build is enabled, but there isn't any more work to do on it that I can see.
,
Dec 7 2016
,
Dec 9 2016
Build flag is in. The about://flags visible changes should show up in the next canary release. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sko...@chromium.org
, Dec 5 2016