Fix up the Preconnect logic for requests that go through Alt Proxy |
|||||||
Issue descriptionCurrently, the preconnect jobs for resources that should be fetched via Alt Proxy preconnect to the TCP/TLS proxy server. We should change that logic to: (i) No-op (Skip) the preconnects if the resolved proxy is a an Alt Proxy and 0-RTT QUIC is possible to the Alt Proxyl (ii) Race the TLS and QUIC jobs if 0-RTT QUIC is not possible
,
Dec 22 2016
,
Dec 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7450edf914e2fedef46171ec5741d17b127df0f0 commit 7450edf914e2fedef46171ec5741d17b127df0f0 Author: tbansal <tbansal@chromium.org> Date: Wed Dec 28 21:12:53 2016 Cleanup the preconnect to proxy code and Job controller code (1) Add a boolean |restrict_to_one_preconnect_for_proxies| to network session params. This allows us to run multiple experiments using a single field trial. Next CL will add the variation param |race_preconnects_to_proxies| to experiment with racing the alternative and main jobs for proxy preconnects. (2) Remove an extra parameter in HttpStreamFactoryImpl::Job::Delegate::OnStreamReady() method. BUG= 667471 ,671291 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2600943002 Cr-Commit-Position: refs/heads/master@{#440893} [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/components/network_session_configurator/network_session_configurator.cc [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/net/http/http_network_session.cc [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/net/http/http_network_session.h [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/net/http/http_stream_factory_impl.cc [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/net/http/http_stream_factory_impl.h [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/net/http/http_stream_factory_impl_job.cc [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/net/http/http_stream_factory_impl_job.h [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/net/http/http_stream_factory_impl_job_controller.cc [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/net/http/http_stream_factory_impl_job_controller.h [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/net/http/http_stream_factory_impl_job_controller_unittest.cc [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/net/http/http_stream_factory_impl_unittest.cc [modify] https://crrev.com/7450edf914e2fedef46171ec5741d17b127df0f0/net/spdy/spdy_test_util_common.cc
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f811aeb9e9174c1b3c097a20fbd201c99694547e commit f811aeb9e9174c1b3c097a20fbd201c99694547e Author: tbansal <tbansal@chromium.org> Date: Tue Jan 24 01:10:47 2017 Add resolved proxy for the http stream job to net log This makes it easier to understand the net log when two racing jobs are created with different proxies (say https://, and quic://). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=671291 Review-Url: https://codereview.chromium.org/2650773004 Cr-Commit-Position: refs/heads/master@{#445574} [modify] https://crrev.com/f811aeb9e9174c1b3c097a20fbd201c99694547e/net/http/http_stream_factory_impl_job.cc [modify] https://crrev.com/f811aeb9e9174c1b3c097a20fbd201c99694547e/net/log/net_log_event_type_list.h
,
May 5 2017
What's the status of this issue?
,
May 5 2017
I have a CL in-flight that has gone through 1 round of review. I need to get back on this.
,
May 5 2017
,
Nov 8 2017
What's the status of this issue? Is it obsolete?
,
Nov 9 2017
No progress yet. It is not obsolete.
,
Nov 9 2017
,
Nov 9 2017
,
Jan 3 2018
Refreshed during triage.
,
Feb 20 2018
Refreshed during triage.
,
Feb 27 2018
,
Mar 26 2018
CL "in-flight": https://codereview.chromium.org/2595413002/
,
Sep 21
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tbansal@chromium.org
, Dec 19 2016