New issue
Advanced search Search tips

Issue 671285 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

interstitial.bad_clock.decision isn't sending any data

Project Member Reported by est...@chromium.org, Dec 5 2016

Issue description

This histogram broke in a refactoring and apparently wasn't tested. :( It stopped sending data sometime in M55 or possibly earlier.
 
After fixing this, it would be a good idea to go through all of the histograms we own and add browser tests if there isn't one. 
Status: WontFix (was: Assigned)
Dug around a bit and found that felt@ deprecated this histogram intentionally in https://codereview.chromium.org/1317593002 because most of the values aren't useful for non-overrideable interstitials (like the bad clock one). Unfortunately I don't see a way to mark this histogram as deprecated in histograms.xml because of the way it's defined with histogram_suffixes.
If it's deprecated, can we remove it? What's the replacement histogram? (it's not immediately clear to me from the CL)

Sign in to add a comment