WebGL 2.0 not supported on open-source AMD drivers on Linux |
||||||
Issue descriptionOn the open-source Mesa / Gallium drivers on Linux for AMD GPUs, WebGL 2.0 is currently not supported. The reason is that the GL_ARB_gpu_shader5 extension isn't supported. The requirement for it was added in cf7b555abc38ee52485c0bbd0ae09a672f3348ce (see https://bugs.chromium.org/p/chromium/issues/detail?id=598902#c35 ). The reason this was added is that ESSL 1.00 (from OpenGL ES 2.0) allows dynamic indexing of sampler arrays, but ESSL 3.00 (from OpenGL ES 3.0) forbids it. There was a thought that we didn't want to regress functionality compared to ESSL 1.00. However, since ESSL 3.00's requirements are more strict than ESSL 1.00 in this area, it's actually not necessary to forbid creation of OpenGL ES 3.0 contexts in Chromium due to a lack of GL_ARB_gpu_shader5. For ES 2.0 contexts, we can leave the support for this functionality undefined (as it has been all along), and for ES 3.0 contexts, we don't need to require its presence. Since this is a small change I'm marking it as R-B-S for M56 and will request a merge as soon as it lands on trunk.
,
Dec 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bd1f057280fea281637bb63265225303c35850a commit 2bd1f057280fea281637bb63265225303c35850a Author: kbr <kbr@chromium.org> Date: Mon Dec 05 20:41:19 2016 Don't require GL_ARB_gpu_shader5 in order to support ES 3.0. ES 3.0 and ESSL 3.00 expressly forbid dynamic indexing of sampler arrays, so don't impose a stricter requirement on the desktop OpenGL drivers than needed. BUG= 671280 Review-Url: https://codereview.chromium.org/2555513002 Cr-Commit-Position: refs/heads/master@{#436392} [modify] https://crrev.com/2bd1f057280fea281637bb63265225303c35850a/ui/gl/gl_version_info.cc
,
Dec 5 2016
Requesting merge to M56. I am pretty sure this will solve the user's problem.
,
Dec 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/729a9c974499e5cd9606bbeced50f14a42534e99 commit 729a9c974499e5cd9606bbeced50f14a42534e99 Author: Corentin Wallez <cwallez@chromium.org> Date: Mon Dec 05 19:22:47 2016 Don't require GL_ARB_gpu_shader5 in order to support ES 3.0. ES 3.0 doesn't require non-constant sampler array indexing, and we can't require it for ES 2 without breaking WebGL for some users. BUG= 671280 Change-Id: Ib04446284acc92410a90c683a3d222871de554a8 Reviewed-on: https://chromium-review.googlesource.com/416195 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/729a9c974499e5cd9606bbeced50f14a42534e99/src/compiler/translator/TranslatorGLSL.cpp [modify] https://crrev.com/729a9c974499e5cd9606bbeced50f14a42534e99/src/libANGLE/renderer/gl/renderergl_utils.cpp
,
Dec 6 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17a173972b70030cd2e278c6adac8bcbe40ac78b commit 17a173972b70030cd2e278c6adac8bcbe40ac78b Author: geofflang <geofflang@chromium.org> Date: Tue Dec 06 21:40:50 2016 Roll ANGLE ced53ae..729a9c9 https://chromium.googlesource.com/angle/angle.git/+log/ced53ae..729a9c9 BUG=None,chromium:661857,671280 TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2555763002 Cr-Commit-Position: refs/heads/master@{#436741} [modify] https://crrev.com/17a173972b70030cd2e278c6adac8bcbe40ac78b/DEPS
,
Dec 6 2016
Thanks for the fix. M56 Beta promotion is scheduled on Dec-8 & RC cut on Wednesday,Dec 7 @ 4.00 PM PST.Please ensure to verify the fix and merge your change ASAP so that we could take it for next release.
,
Dec 9 2016
***BULK EDIT*** Your change has been approved for M56. Please ensure to verify the fix and merge ASAP so that we could take it for next Beta Release. If the change is already merged and no pending work please remove Merge-Approved-56 label and add merge-merged-2924.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d09e35b60a6888deb59a1bc13a2748a209dc3e29 commit d09e35b60a6888deb59a1bc13a2748a209dc3e29 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Dec 09 02:59:15 2016 Don't require GL_ARB_gpu_shader5 in order to support ES 3.0. ES 3.0 and ESSL 3.00 expressly forbid dynamic indexing of sampler arrays, so don't impose a stricter requirement on the desktop OpenGL drivers than needed. BUG= 671280 Review-Url: https://codereview.chromium.org/2555513002 Cr-Commit-Position: refs/heads/master@{#436392} (cherry picked from commit 2bd1f057280fea281637bb63265225303c35850a) Review URL: https://codereview.chromium.org/2560113002 . Cr-Commit-Position: refs/branch-heads/2924@{#424} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/d09e35b60a6888deb59a1bc13a2748a209dc3e29/ui/gl/gl_version_info.cc
,
Dec 13 2016
Submitter verified that this is working now on his system.
,
Jan 30 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kbr@chromium.org
, Dec 5 2016