New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671269 link

Starred by 14 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Emacs shortcuts broken in developer console

Reported by s...@papertrail.com, Dec 5 2016

Issue description

Chrome Version       : Version 55.0.2883.75 (64-bit) (and 57.0.2939.0 canary)
URLs (if applicable) : NA
OS version               : 10.11.6
Behavior in Safari (if applicable): NA
Behavior in Firefox (if applicable): NA

What steps will reproduce the problem?
(1) Open up developer console
(2) emacs shortcuts no longer work (other than control + a and control + e)

What is the expected result?

control + f, control + b, control + d, etc. are enormous parts of my workflow. They still work in text boxes and in the URL bar. What needs to be done to fix this in chrome developer tools console?

What happens instead?

Nothing

 
Components: Platform>DevTools
Labels: -Type-Bug Type-Bug-Regression

Comment 2 by ajha@chromium.org, Dec 6 2016

Labels: M-57

Comment 3 by ajha@chromium.org, Dec 6 2016

Cc: pbomm...@chromium.org gov...@chromium.org ajha@chromium.org
Labels: -Pri-3 -M-57 M-55 ReleaseBlock-Stable pre-stable-55.0.2883.75 hasbisect-per-revision Pri-1
Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on the latest canary(57.0.2942.0) and the latest stable(55.0.2883.75) on Mac OS 10.11.6.

Regressed in M-55.

Last good build: 55.0.2862.0
First bad build: 55.0.2863.0

Changelog:
==========
https://chromium.googlesource.com/chromium/src/+log/e0f27b9808ea6a7333669e2404be671fd4231d00..fd9f42976b2d7c512f5242dffe713bfa06c22a9c
 
einbinder@: Could you please take a look at this.

Marking this as Stable blocker for M-55 for consideration of next stable refresh. Feel free to adjust the label if this shouldn't be blocking.

Note: Emacs shortcuts doesn't work on Windows and Linux.


[Bulk edit]

URGENT - PTAL ASAP.

This issue is marked as a stable release blocker for this week M55 Stable release cut, pls make sure to land the fix and get it merged to release branch ASAP.

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.


Thanks!
Labels: -M-55 -OS-Mac M-56 OS-All
Moving to 56.
Labels: -ReleaseBlock-Stable
Status: Started (was: Assigned)
Labels: -pre-stable-55.0.2883.75 prestable-55.0.2883.75
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/247b2e4c45b9e2504c54a0725f39df52d8c071b2

commit 247b2e4c45b9e2504c54a0725f39df52d8c071b2
Author: einbinder <einbinder@chromium.org>
Date: Fri Dec 09 03:51:14 2016

DevTools: Add more Mac shortcuts into CodeMirrorTextEditor

MacOS has a lot of Emacs-style keyboard shortcuts that we lost when
moving the console from contenteditable to CodeMirror.

BUG= 671269 

Review-Url: https://codereview.chromium.org/2559603002
Cr-Commit-Position: refs/heads/master@{#437457}

[modify] https://crrev.com/247b2e4c45b9e2504c54a0725f39df52d8c071b2/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js

Labels: Merge-Request-56
Status: Fixed (was: Started)

Comment 11 by dimu@chromium.org, Dec 12 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Thanks for the fix, we will verify in latest canary and if all look good please merge to M56 branch.
Project Member

Comment 13 by sheriffbot@chromium.org, Dec 16 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 19 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Your change has been approved for M56. Beta RC cut is scheduled at 3.00 PM today 01/03, please merged the CL ASAP.

Comment 16 Deleted

Gentle reminder for merge.
Your change is approved for M56, if all looks good, please merge the CL ASAP.
We are planning to cut Beta RC today 01/10 at 4.00 PM PST.
Ping to merge the CL.
Cc: lushnikov@chromium.org
Please merge your change ASAP, M56 Stable RC cut is at 4.00 PM today 1/24.

Comment 21 by kayce@google.com, Jan 26 2017

Labels: DevTools-Release-Notes-Bug
Labels: -Merge-Approved-56 merge-merged-2924
Fix already merged in M56.

https://chromium.googlesource.com/chromium/src.git/+/edfa3ce871a7748b1e7b8162f9ceb409a613b965
Labels: TE-Verified-M56 TE-Verified-56.0.2924.87
Tested the issue on Mac 10.12.2 using chrome version 56.0.2924.87.
Emacs shortcuts control + f, control + b, control + d are working fine without any issues.
Please find the attached screen cast for the same.

Adding TE-Verified labels.

Thanks,
671269.mp4
398 KB View Download

Comment 24 by ajha@chromium.org, Feb 3 2017

Cc: einbinder@chromium.org
 Issue 686477  has been merged into this issue.

Comment 25 by kayce@google.com, Feb 7 2017

Labels: -DevTools-Release-Notes-Bug
Cc: nyerramilli@chromium.org l...@chromium.org
 Issue 656251  has been merged into this issue.

Sign in to add a comment