"org.chromium.chrome.browser.incognito.IncognitoNotificationServiceTest#testSingleRunningChromeTabbedActivity" is flaky |
|||||||||
Issue description"org.chromium.chrome.browser.incognito.IncognitoNotificationServiceTest#testSingleRunningChromeTabbedActivity" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNydwsSBUZsYWtlImxvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuaW5jb2duaXRvLkluY29nbml0b05vdGlmaWNhdGlvblNlcnZpY2VUZXN0I3Rlc3RTaW5nbGVSdW5uaW5nQ2hyb21lVGFiYmVkQWN0aXZpdHkM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Dec 5 2016
Failing w/ a native crash: I 301.340s run_tests_on_device(06abe9f5003b6bb2) detected failure in org.chromium.chrome.browser.incognito.IncognitoNotificationServiceTest#testSingleRunningChromeTabbedActivity. raw output: I 301.340s run_tests_on_device(06abe9f5003b6bb2) INSTRUMENTATION_STATUS: numtests=1 I 301.340s run_tests_on_device(06abe9f5003b6bb2) INSTRUMENTATION_STATUS: stream= I 301.340s run_tests_on_device(06abe9f5003b6bb2) org.chromium.chrome.browser.incognito.IncognitoNotificationServiceTest: I 301.340s run_tests_on_device(06abe9f5003b6bb2) INSTRUMENTATION_STATUS: id=InstrumentationTestRunner I 301.340s run_tests_on_device(06abe9f5003b6bb2) INSTRUMENTATION_STATUS: test=testSingleRunningChromeTabbedActivity I 301.340s run_tests_on_device(06abe9f5003b6bb2) INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.incognito.IncognitoNotificationServiceTest I 301.340s run_tests_on_device(06abe9f5003b6bb2) INSTRUMENTATION_STATUS: current=1 I 301.340s run_tests_on_device(06abe9f5003b6bb2) INSTRUMENTATION_STATUS_CODE: 1 I 301.340s run_tests_on_device(06abe9f5003b6bb2) INSTRUMENTATION_RESULT: shortMsg=Process crashed. I 301.340s run_tests_on_device(06abe9f5003b6bb2) INSTRUMENTATION_CODE: 0
,
Dec 7 2016
tedchoc@, could you take look, since you introduced this test[1]? [1] http://crrev.com/1863453002 Initial tests for the IncognitoNotificationService
,
Dec 7 2016
@jbudorick -- I assume these are bots that have no way to symbolize the stack trace? I see the following: Device(00e9e39a38d69a81) 12-07 14:48:04.327 32571 32714 E chromium: [ERROR:native_library_runner.cc(46)] Failed to load library (path: /data/app/org.chromium.chrome-1/lib/arm64/content_browser/content_browser.library reason: dlopen failed: library "/data/app/org.chromium.chrome-1/lib/arm64/content_browser/content_browser.library" not found) Device(00e9e39a38d69a81) 12-07 14:48:04.350 32571 32714 F chromium: [FATAL:init.cc(86)] Check failed: init_function Device(00e9e39a38d69a81) 12-07 14:48:04.353 32571 32628 F chromium: [FATAL:thread_restrictions.cc(38)] Check failed: false. Function marked as IO-only was called from a thread that disallows IO! If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup. Something is definitely going wrong, but I don't know if this test is just tickling some other bug or is actually broken itself without seeing the stack.
,
Dec 7 2016
For now, that's correct. As mentioned offline, though, this also crashed on one of the bots where we do symbolize traces: https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/6640 Specifically, see https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/6640/steps/chrome_public_test_apk%3A%20generate%20result%20details/logs/result_details
,
Dec 7 2016
+jam, +jamescook for the stacks below. FWIW, this test is creating incognito tabs very quickly and then destroying them, which will cause the incongito profile to be destroyed. I "suspect" this is hitting some race with the destruction path that we don't normally encounter. (If you click on the second like in #5 from jbudorick@, search for "testSingleRunningChromeTabbedActivity" and click on the read CRASHED box, you'll see the full output). Here are what I believe to be a couple relevant stacks: ---------- [FATAL:thread_restrictions.cc(38)] Check failed: false. Function marked as IO-only was called from a thread that disallows IO! If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup. 004151cf base::ThreadRestrictions::AssertIOAllowed() /b/c/b/Android_arm_Builder__dbg_/src/base/threading/thread_restrictions.cc:38 0040e69f base::PlatformThread::Join(base::PlatformThreadHandle) /b/c/b/Android_arm_Builder__dbg_/src/base/threading/platform_thread_posix.cc:220 00412907 base::SimpleThread::Join() /b/c/b/Android_arm_Builder__dbg_/src/base/threading/simple_thread.cc:48 01abb635 service_manager::InProcessNativeRunner::~InProcessNativeRunner() /b/c/b/Android_arm_Builder__dbg_/src/services/service_manager/runner/host/in_process_native_runner.cc:34 01abb6a3 service_manager::InProcessNativeRunner::~InProcessNativeRunner() ---------- [FATAL:init.cc(86)] Check failed: init_function. 1/lib/arm/libchrome.so 018040a7 content::StartServerOnHandlerThread(base::WeakPtr<content::DevToolsHttpHandler>, base::Thread*, content::DevToolsSocketFactory*, base::FilePath const&, base::FilePath const&, bool) /b/c/b/Android_arm_Builder__dbg_/src/content/browser/devtools/devtools_http_handler.cc:229 v------> scoped_refptr<content::DevToolsAgentHost>::swap(content::DevToolsAgentHost**) /b/c/b/Android_arm_Builder__dbg_/src/base/memory/ref_counted.h:360 v------> scoped_refptr<content::DevToolsAgentHost>::swap(scoped_refptr<content::DevToolsAgentHost>&) /b/c/b/Android_arm_Builder__dbg_/src/base/memory/ref_counted.h:364 01803751 scoped_refptr<content::DevToolsAgentHost>::operator=(scoped_refptr<content::DevToolsAgentHost>&&) ---------
,
Dec 7 2016
I don't have much to add here -- those stack snippets don't look familiar to me and I can't find the full stacks to see if there's something more relevant above. +rockot since I see service_manager::InProcessNativeRunner in the first one
,
Dec 8 2016
Yeah, sorry, those stacks don't look at all familiar to me.
,
Dec 8 2016
Ken: looks like service manager related?
,
Dec 8 2016
Yep, looks like BrowserContext creation/destruction racing with render process creation/destruction.
,
Dec 8 2016
I'm disabling the flaky test in https://codereview.chromium.org/2559203002
,
Dec 8 2016
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e517dc2eb8f6417e64a15059116e2040b86bb476 commit e517dc2eb8f6417e64a15059116e2040b86bb476 Author: treib <treib@chromium.org> Date: Thu Dec 08 17:16:07 2016 Disable flaky IncognitoNotificationServiceTest#testSingleRunningChromeTabbedActivity TBR=rockot@chromium.org,tedchoc@chromium.org BUG= 671268 Review-Url: https://codereview.chromium.org/2559203002 Cr-Commit-Position: refs/heads/master@{#437270} [modify] https://crrev.com/e517dc2eb8f6417e64a15059116e2040b86bb476/chrome/android/javatests/src/org/chromium/chrome/browser/incognito/IncognitoNotificationServiceTest.java
,
Dec 8 2016
,
Dec 16 2016
Issue 674654 has been merged into this issue.
,
Dec 16 2016
It looks like the same change also broke UndoTabModelTest#testUndoNotSupported
,
Dec 16 2016
I'm going to re-enable the disabled test, as the flake (and the flake mentioned in #17) should be fixed by https://codereview.chromium.org/2557213002
,
Dec 16 2016
Correction, upon closer inspection the flake in #17 is something else. Either way, this should be fixed.
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/289f5bc28ed08151664f28e085ec6d2ed26cb3c6 commit 289f5bc28ed08151664f28e085ec6d2ed26cb3c6 Author: rockot <rockot@chromium.org> Date: Fri Dec 16 23:37:39 2016 Re-enable IncognitoNotificationServiceTest.testSingleRunningChromeTabbedActivity BUG= 671268 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2586603002 Cr-Commit-Position: refs/heads/master@{#439231} [modify] https://crrev.com/289f5bc28ed08151664f28e085ec6d2ed26cb3c6/chrome/android/javatests/src/org/chromium/chrome/browser/incognito/IncognitoNotificationServiceTest.java
,
Dec 16 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jbudorick@chromium.org
, Dec 5 2016