Refactor manifest_version.SlaveStatus |
||
Issue descriptioncurrently BuildSpecsManager needs to check all slave builds to decide whether to wait for slaves. 1) Refactor manifest_version.SlaveStatus so it only needs to query CIDB or Buildbucket for not completed builds. 2) Separate the SlaveStatus and BuilderStatus out from manfest_version.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b8b608ed2b224c47812e67b302a2c006bb03528a commit b8b608ed2b224c47812e67b302a2c006bb03528a Author: Ningning Xia <nxia@chromium.org> Date: Tue Dec 06 18:20:54 2016 Move SlaveStatus to build_status and refactor SlaveStatus. 1) Move SlaveStatus to build_status.py and unit tests to build_status_unittest.py 2) Refactor SlaveStatus to query CIDB and buildbucket for builds not in completed_builds. 3) Move the motheds of query_cidb, query_buildbucket, retry_builds into SlaveStatus. BUG= chromium:671267 TEST=unit_tests Change-Id: I743f144ad7594dd8b40f1f2e03e26fe9cc5e7803 Reviewed-on: https://chromium-review.googlesource.com/417103 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [add] https://crrev.com/b8b608ed2b224c47812e67b302a2c006bb03528a/cbuildbot/build_status_unittest.py [modify] https://crrev.com/b8b608ed2b224c47812e67b302a2c006bb03528a/cbuildbot/manifest_version_unittest.py [modify] https://crrev.com/b8b608ed2b224c47812e67b302a2c006bb03528a/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/b8b608ed2b224c47812e67b302a2c006bb03528a/cbuildbot/manifest_version.py [add] https://crrev.com/b8b608ed2b224c47812e67b302a2c006bb03528a/cbuildbot/build_status_unittest [add] https://crrev.com/b8b608ed2b224c47812e67b302a2c006bb03528a/cbuildbot/build_status.py
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b43ebae1476994760187d41a2d7c583b3a8eec81 commit b43ebae1476994760187d41a2d7c583b3a8eec81 Author: Ningning Xia <nxia@chromium.org> Date: Sat Dec 10 02:11:09 2016 Get and update builds_to_retry when needed 1) Only allow ShouldWait and UpdateSlaveStatus to be public methods. 2) Only call _GetBuildsToRetry once in each UpdateSlaveStatus run. 3) ShouldWait should update self.builds_to_retry after _RetryBuilds. BUG= chromium:671267 TEST=unit_tests Change-Id: I9547f17617d1e4e85ebdf1b21bfa8b1a202be383 Reviewed-on: https://chromium-review.googlesource.com/418513 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/b43ebae1476994760187d41a2d7c583b3a8eec81/cbuildbot/build_status_unittest.py [modify] https://crrev.com/b43ebae1476994760187d41a2d7c583b3a8eec81/cbuildbot/build_status.py [modify] https://crrev.com/b43ebae1476994760187d41a2d7c583b3a8eec81/cbuildbot/manifest_version_unittest.py
,
Dec 14 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by nxia@chromium.org
, Dec 5 2016