New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671262 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 755418



Sign in to add a comment

Improve download warning logic for files on internal network

Project Member Reported by jialiul@chromium.org, Dec 5 2016

Issue description

If the download file is hosted on a local network (e.g non-routable IPs), we probably should not show uncommon warning. However, we should still check and warn for malware/UwS.

 

Comment 1 by vakh@chromium.org, Jun 30 2017

Description: Show this description

Comment 2 by vakh@chromium.org, Jun 30 2017

Owner: nparker@chromium.org
Status: Assigned (was: Available)
Cc: mortonm@google.com
+mortonm@, interested in taking a look?

Comment 4 by mortonm@google.com, Aug 14 2017

Sure, I can take a look :)

Comment 5 by mortonm@google.com, Aug 18 2017

Didn't have time to finish this CL, but I'll give some pointers for how it could be done:

- DownloadItem object has member containing source IP address of the download https://cs.chromium.org/chromium/src/content/public/browser/download_item.h?rcl=793e8467869415cc6c07a6fde151a1c49e10c600&l=272

- Use a function like this one https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/client_side_detection_service.h?rcl=e478f74685cfc037c63a87ab25745a52ae251220&l=120 to check whether the source IP is on the internal network

- For non-Mac, add an extra check here to avoid showing warning when file came from internal network and was labeled as uncommon: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/download/download_item_view.cc?rcl=960de3d987f6b5e35fac71e448c2c4e73775fba7&l=279

- For Mac, this seems like the place to do the equivalent thing: https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/download/download_item_controller.mm?rcl=7c6511d4eed31fa175d7d29f933f1c7c35e3ae8e&l=142


Comment 6 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 7 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt
Blockedon: 755418
Cc: jialiul@chromium.org chinta@chromium.org nparker@chromium.org
 Issue 450684  has been merged into this issue.
Status: Fixed (was: Assigned)
The non-routable IP check is done on the backend (added after this bug was filed). So this should be fixed.

Sign in to add a comment