Issue metadata
Sign in to add a comment
|
Cookie sort broken for string columns |
||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2939.0 OS: OSX 10.11.6 What steps will reproduce the problem? (1) Open Application tab and view the cookies table (2) Click on the "Name", "Value", "Path", or "Domain" headers to adjust the sort direction What is the expected result? The table of cookies is sorted by the appropriate value What happens instead? Nothing
,
Dec 6 2016
We'll need to merge the fix to M56 branch.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cbb9199efb2e4996c77e67982cf8a55bed4df3d commit 6cbb9199efb2e4996c77e67982cf8a55bed4df3d Author: phulce <phulce@chromium.org> Date: Fri Dec 09 19:13:40 2016 [DevTools] Fix Cookie Sort Adjust CookiesTable comparator to get the correct property for string comparisons. BUG= 671251 Review-Url: https://codereview.chromium.org/2550213002 Cr-Commit-Position: refs/heads/master@{#437605} [add] https://crrev.com/6cbb9199efb2e4996c77e67982cf8a55bed4df3d/third_party/WebKit/LayoutTests/inspector/components/cookies-table-expected.txt [add] https://crrev.com/6cbb9199efb2e4996c77e67982cf8a55bed4df3d/third_party/WebKit/LayoutTests/inspector/components/cookies-table.html [modify] https://crrev.com/6cbb9199efb2e4996c77e67982cf8a55bed4df3d/third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js
,
Dec 12 2016
Verified the issue on windows 10, Mac 10.12.1 and Ubuntu 14.04 using latest canary #57.0.2949.0 as per comment #0 Observed that the table of cookies got sorted by the appropriate value after clicking on name or value. Hence, the fix is working as expected. Attaching screen cast for reference. Hence, adding the verified labels. Thanks...!!
,
Dec 12 2016
Thanks @krajshree, requesting merge to 56 then to avoid regression
,
Dec 12 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87a8b02d34e662c30a55b01a30fdcaa274902c87 commit 87a8b02d34e662c30a55b01a30fdcaa274902c87 Author: phulce <phulce@chromium.org> Date: Mon Dec 12 19:52:56 2016 [DevTools] Fix Cookie Sort Adjust CookiesTable comparator to get the correct property for string comparisons. BUG= 671251 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2550213002 Cr-Commit-Position: refs/heads/master@{#437605} (cherry picked from commit 6cbb9199efb2e4996c77e67982cf8a55bed4df3d) Review-Url: https://codereview.chromium.org/2569833002 Cr-Commit-Position: refs/branch-heads/2924@{#466} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [add] https://crrev.com/87a8b02d34e662c30a55b01a30fdcaa274902c87/third_party/WebKit/LayoutTests/inspector/components/cookies-table-expected.txt [add] https://crrev.com/87a8b02d34e662c30a55b01a30fdcaa274902c87/third_party/WebKit/LayoutTests/inspector/components/cookies-table.html [modify] https://crrev.com/87a8b02d34e662c30a55b01a30fdcaa274902c87/third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js
,
Dec 12 2016
,
Dec 14 2016
Tested the same on win10 mac 10.11.6 and Linux 14.04 chrome version 56.0.2924.28 - The table of cookies is sorted by the appropriate value clicking on headers. Please find the screencast Fix works as expected
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by phulce@chromium.org
, Dec 6 2016