New issue
Advanced search Search tips

Issue 671246 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Sign in to add a comment

Minimize ash porting layer

Project Member Reported by sky@chromium.org, Dec 5 2016

Issue description

Ash with classic aura and aura-mus will have some slight differences. We likely don't need what is ash/common and instead a slightly different layer. This bug is to unravel current ash/common and figure out the right porting layer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/307e3589d858c808490ec46f5dad414a97b1a544

commit 307e3589d858c808490ec46f5dad414a97b1a544
Author: sky <sky@chromium.org>
Date: Thu Jan 05 17:30:24 2017

Removes/promotes functions from WmWindowMus to WmWindowAura

The aura implementation for many of these can be used as is.

BUG= 671246 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2613793002
Cr-Commit-Position: refs/heads/master@{#441689}

[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/aura/wm_window_aura.h
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/common/wm_window.h
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/mus/BUILD.gn
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/mus/bridge/wm_window_mus.h
[delete] https://crrev.com/867f4553745f6106db762b4260397740760aaacf/ash/mus/bridge/wm_window_mus_test_api.cc
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/mus/non_client_frame_controller.cc
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/mus/test/wm_test_base.cc
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/mus/test/wm_test_base.h
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/test/BUILD.gn
[add] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/test/wm_window_aura_test_api.cc
[rename] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/test/wm_window_aura_test_api.h
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/wm/window_properties.cc
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ash/wm/window_properties.h
[modify] https://crrev.com/307e3589d858c808490ec46f5dad414a97b1a544/ui/views/widget/native_widget_aura.cc

Comment 2 by sky@chromium.org, Jan 5 2017

Labels: mustash-1

Comment 3 by sky@chromium.org, Jan 5 2017

Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 6 2017

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ec2be8dc762f1398c2bb0f3cb278d05269d3067

commit 4ec2be8dc762f1398c2bb0f3cb278d05269d3067
Author: sky <sky@chromium.org>
Date: Fri Jan 06 17:38:32 2017

Removes some dead code

I also removed some ifdefs that are no longer necessary and some
windows code that isn't needed.

BUG= 671246 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2611253002
Cr-Commit-Position: refs/heads/master@{#441963}

[modify] https://crrev.com/4ec2be8dc762f1398c2bb0f3cb278d05269d3067/ash/BUILD.gn
[modify] https://crrev.com/4ec2be8dc762f1398c2bb0f3cb278d05269d3067/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/4ec2be8dc762f1398c2bb0f3cb278d05269d3067/ash/display/window_tree_host_manager.h
[modify] https://crrev.com/4ec2be8dc762f1398c2bb0f3cb278d05269d3067/ash/host/ash_window_tree_host.cc
[modify] https://crrev.com/4ec2be8dc762f1398c2bb0f3cb278d05269d3067/ash/host/ash_window_tree_host.h
[delete] https://crrev.com/31c6ef91f565a59348aad61bfadd3c954a3b0552/ash/host/ash_window_tree_host_win.cc
[delete] https://crrev.com/31c6ef91f565a59348aad61bfadd3c954a3b0552/ash/host/ash_window_tree_host_win.h
[modify] https://crrev.com/4ec2be8dc762f1398c2bb0f3cb278d05269d3067/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/4ec2be8dc762f1398c2bb0f3cb278d05269d3067/ash/mus/bridge/wm_root_window_controller_mus.h
[modify] https://crrev.com/4ec2be8dc762f1398c2bb0f3cb278d05269d3067/ash/shell.cc
[modify] https://crrev.com/4ec2be8dc762f1398c2bb0f3cb278d05269d3067/ash/shell.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21adf48e93469ae8be2fbbf7d47806a574127b0f

commit 21adf48e93469ae8be2fbbf7d47806a574127b0f
Author: sky <sky@chromium.org>
Date: Fri Jan 06 20:30:03 2017

Remove DCHECK in WmWindowMus::CloseWidget()

And improve comment. Additionally removes some dead includes in
RootWindowController.

BUG= 671246 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2610853012
Cr-Commit-Position: refs/heads/master@{#442029}

[modify] https://crrev.com/21adf48e93469ae8be2fbbf7d47806a574127b0f/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/21adf48e93469ae8be2fbbf7d47806a574127b0f/ash/root_window_controller.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/287fe73741d070d48c332cd95849bd73e2eb722e

commit 287fe73741d070d48c332cd95849bd73e2eb722e
Author: sky <sky@chromium.org>
Date: Mon Jan 09 22:29:18 2017

Removes WmShelfAura and WmShelfMus

Differences are consolidated in WmShelf for now.

BUG= 671246 
TEST=none

Review-Url: https://codereview.chromium.org/2626483002
Cr-Commit-Position: refs/heads/master@{#442376}

[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/BUILD.gn
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/aura/wm_root_window_controller_aura.cc
[delete] https://crrev.com/59bdd9ec771b134936b325af8b80b0ee5d8b8231/ash/aura/wm_shelf_aura.cc
[delete] https://crrev.com/59bdd9ec771b134936b325af8b80b0ee5d8b8231/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/common/shelf/wm_shelf.cc
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/mus/BUILD.gn
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/mus/bridge/wm_root_window_controller_mus.cc
[delete] https://crrev.com/59bdd9ec771b134936b325af8b80b0ee5d8b8231/ash/mus/bridge/wm_shelf_mus.cc
[delete] https://crrev.com/59bdd9ec771b134936b325af8b80b0ee5d8b8231/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/mus/root_window_controller.cc
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/mus/root_window_controller.h
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/root_window_controller.cc
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/root_window_controller.h
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/screen_util.cc
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/287fe73741d070d48c332cd95849bd73e2eb722e/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00f98a37895bba109714215198be8e99b3826cdc

commit 00f98a37895bba109714215198be8e99b3826cdc
Author: sky <sky@chromium.org>
Date: Wed Jan 11 06:03:49 2017

Removes WmRootWindowController subclasses

And makes mash use RootWindowController directly. My next step is to
fold WmRootWindowController back into RootWindowController.

BUG= 671246 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2620913003
Cr-Commit-Position: refs/heads/master@{#442817}

[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/BUILD.gn
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/aura/wm_lookup_aura.cc
[delete] https://crrev.com/46a10c19dab82172fb82578b062b8929600cf376/ash/aura/wm_root_window_controller_aura.cc
[delete] https://crrev.com/46a10c19dab82172fb82578b062b8929600cf376/ash/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/common/wm_root_window_controller.cc
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/common/wm_root_window_controller.h
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/mus/BUILD.gn
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/mus/bridge/wm_lookup_mus.cc
[delete] https://crrev.com/46a10c19dab82172fb82578b062b8929600cf376/ash/mus/bridge/wm_root_window_controller_mus.cc
[delete] https://crrev.com/46a10c19dab82172fb82578b062b8929600cf376/ash/mus/bridge/wm_root_window_controller_mus.h
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/mus/root_window_controller.cc
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/mus/root_window_controller.h
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/mus/window_manager.cc
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/mus/window_manager.h
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/root_window_controller.cc
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/root_window_controller.h
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/shell.cc
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/shell.h
[modify] https://crrev.com/00f98a37895bba109714215198be8e99b3826cdc/ash/wm/always_on_top_controller_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b664383006661b34cbe214ace8d488e684cb6670

commit b664383006661b34cbe214ace8d488e684cb6670
Author: sky <sky@chromium.org>
Date: Wed Jan 11 22:08:45 2017

Folds WmRootWindowController into RootWindowController

This is (mostly) the bare minimum to merge the two. Future patches
will cleanup WmWindow usage.

BUG= 671246 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2620153003
Cr-Commit-Position: refs/heads/master@{#443003}

[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/BUILD.gn
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/aura/wm_lookup_aura.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/aura/wm_lookup_aura.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/aura/wm_window_aura.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/accelerators/accelerator_controller.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/accelerators/debug_commands.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/accelerators/exit_warning_handler.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/devtools/ash_devtools_dom_agent.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/devtools/ash_devtools_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/drag_drop/drag_image_view.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/shelf/overflow_bubble_view.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/shelf/shelf_controller.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/shelf/shelf_tooltip_manager.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/shelf/shelf_widget.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/shelf/wm_shelf.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/chromeos/audio/tray_audio.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/chromeos/palette/palette_tray.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/chromeos/session/logout_confirmation_dialog.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/status_area_widget.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/status_area_widget_delegate.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/toast/toast_overlay.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/tray/system_tray_controller.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/user/user_view.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/test/ash_test.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wallpaper/wallpaper_view.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wallpaper/wallpaper_widget_controller.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wallpaper/wallpaper_widget_controller.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/container_finder.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/default_state.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/dock/docked_window_layout_manager.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/dock/docked_window_resizer.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/maximize_mode/workspace_backdrop_delegate.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/overview/window_selector.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/panels/panel_layout_manager.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/panels/panel_window_resizer.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/root_window_finder.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/window_cycle_list.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/window_positioning_utils.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/wm_screen_util.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/workspace/multi_window_resize_controller.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/workspace/phantom_window_controller.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/workspace/workspace_layout_manager.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm/workspace_controller.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm_lookup.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm_root_window_controller.cc
[delete] https://crrev.com/5221fd1d6caa0d84ad5a0f8abb4bd745f0170b94/ash/common/wm_root_window_controller.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm_shell.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm_shell.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/common/wm_window.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/mus/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/mus/bridge/wm_lookup_mus.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/mus/bridge/wm_lookup_mus.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/mus/window_manager.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/root_window_controller.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/root_window_controller.h
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/shell.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/shell_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/test/ash_test_base.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/wm/always_on_top_controller_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/wm/window_util.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc
[modify] https://crrev.com/b664383006661b34cbe214ace8d488e684cb6670/chrome/browser/ui/ash/system_tray_client_browsertest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d20a89e7b56ad53a58f19edf4775528d066577d5

commit d20a89e7b56ad53a58f19edf4775528d066577d5
Author: sky <sky@chromium.org>
Date: Thu Jan 12 01:28:35 2017

Moves definitions of RootWindowController into root_window_controller.cc

As part of this I made sure the definitions and declarations matched
up. This resulted in reordering a couple of things. In addition the
only other non-move I did was moving what was CreateLayoutManagers()
into InitLayoutManagers() and CloseChildWindowsImpl() into
CloseChildWindows().

BUG= 671246 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2628973002
Cr-Commit-Position: refs/heads/master@{#443109}

[modify] https://crrev.com/d20a89e7b56ad53a58f19edf4775528d066577d5/ash/BUILD.gn
[delete] https://crrev.com/2b7b8dafe5412ef81b6c4755bdbf700bd55d138a/ash/common/wm_root_window_controller.cc
[modify] https://crrev.com/d20a89e7b56ad53a58f19edf4775528d066577d5/ash/root_window_controller.cc
[modify] https://crrev.com/d20a89e7b56ad53a58f19edf4775528d066577d5/ash/root_window_controller.h

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07724bd484c9d39978b231f3e106689067a1e832

commit 07724bd484c9d39978b231f3e106689067a1e832
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Jan 12 02:25:09 2017

Revert of Moves definitions of RootWindowController into root_window_controller.cc (patchset #2 id:20001 of https://codereview.chromium.org/2628973002/ )

Reason for revert:
Attempting to resolve error in
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/ChromiumOS%20amd64-generic%20Compile/builds/28853

>On 2017/01/11 22:44:48, James Cook wrote:
>> FYI I have a CL that deletes this method. We'll see who lands first.
> Done.

It looks like jamescook@ committed a bit more than four minutes earlier.
-- sheriff.

Original issue's description:
> Moves definitions of RootWindowController into root_window_controller.cc
>
> As part of this I made sure the definitions and declarations matched
> up. This resulted in reordering a couple of things. In addition the
> only other non-move I did was moving what was CreateLayoutManagers()
> into InitLayoutManagers() and CloseChildWindowsImpl() into
> CloseChildWindows().
>
> BUG= 671246 
> TEST=none
> R=jamescook@chromium.org
>
> Review-Url: https://codereview.chromium.org/2628973002
> Cr-Commit-Position: refs/heads/master@{#443109}
> Committed: https://chromium.googlesource.com/chromium/src/+/d20a89e7b56ad53a58f19edf4775528d066577d5

TBR=jamescook@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 671246 

Review-Url: https://codereview.chromium.org/2623393002
Cr-Commit-Position: refs/heads/master@{#443117}

[modify] https://crrev.com/07724bd484c9d39978b231f3e106689067a1e832/ash/BUILD.gn
[add] https://crrev.com/07724bd484c9d39978b231f3e106689067a1e832/ash/common/wm_root_window_controller.cc
[modify] https://crrev.com/07724bd484c9d39978b231f3e106689067a1e832/ash/root_window_controller.cc
[modify] https://crrev.com/07724bd484c9d39978b231f3e106689067a1e832/ash/root_window_controller.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fbb8cde3b9aa70029c2ceb9b492b446675f1877

commit 0fbb8cde3b9aa70029c2ceb9b492b446675f1877
Author: sky <sky@chromium.org>
Date: Thu Jan 12 06:07:53 2017

Moves definitions of RootWindowController into root_window_controller.cc

As part of this I made sure the definitions and declarations matched
up. This resulted in reordering a couple of things. In addition the
only other non-move I did was moving what was CreateLayoutManagers()
into InitLayoutManagers() and CloseChildWindowsImpl() into
CloseChildWindows().

BUG= 671246 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2628973002
Cr-Original-Commit-Position: refs/heads/master@{#443109}
Committed: https://chromium.googlesource.com/chromium/src/+/d20a89e7b56ad53a58f19edf4775528d066577d5
Review-Url: https://codereview.chromium.org/2628973002
Cr-Commit-Position: refs/heads/master@{#443166}

[modify] https://crrev.com/0fbb8cde3b9aa70029c2ceb9b492b446675f1877/ash/BUILD.gn
[delete] https://crrev.com/904b7a6f6dffa9cee5ac930c37dd591c330d14c6/ash/common/wm_root_window_controller.cc
[modify] https://crrev.com/0fbb8cde3b9aa70029c2ceb9b492b446675f1877/ash/root_window_controller.cc
[modify] https://crrev.com/0fbb8cde3b9aa70029c2ceb9b492b446675f1877/ash/root_window_controller.h

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8b222fa08f6024ff547f1f35ee219abde6ee511

commit a8b222fa08f6024ff547f1f35ee219abde6ee511
Author: sky <sky@chromium.org>
Date: Thu Jan 12 15:47:13 2017

Promotes WmWindowMus functions to WmWindowAura and nukes WmWindowMus

WmWindowMus and WmWindowAura only differ in a couple of ways that are
better isolated in WmWindowAura rather than two separate classes.

Next I'm going to rename WmWindowAura to WmWindow.

BUG= 671246 
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2625873007
Cr-Commit-Position: refs/heads/master@{#443239}

[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/aura/wm_window_aura.h
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/BUILD.gn
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/accelerators/accelerator_controller_registrar.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/bridge/wm_lookup_mus.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/bridge/wm_shell_mus.cc
[delete] https://crrev.com/0e654809e356d38cdca4b57904bba2a85dd260f2/ash/mus/bridge/wm_window_mus.cc
[delete] https://crrev.com/0e654809e356d38cdca4b57904bba2a85dd260f2/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/disconnected_app_handler.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/frame/detached_title_area_renderer.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/move_event_handler.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/move_event_handler.h
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/non_client_frame_controller.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/root_window_controller.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/root_window_controller.h
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/test/ash_test_impl_mus.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/window_manager.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/mus/window_manager.h
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/shell.cc
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/shell.h
[modify] https://crrev.com/a8b222fa08f6024ff547f1f35ee219abde6ee511/ash/test/wm_window_aura_test_api.h

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3

commit 5dbc91d59a8f1fbfd4987f8539ee032fe29481c3
Author: sky <sky@chromium.org>
Date: Fri Jan 13 00:26:14 2017

chromeos: Renames WmWindowAura to WmWindow

BUG= 671246 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2629643002
Cr-Commit-Position: refs/heads/master@{#443408}

[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/BUILD.gn
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/accelerators/accelerator_delegate.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/aura/aura_layout_manager_adapter.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/aura/wm_lookup_aura.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/aura/wm_shell_aura.cc
[delete] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ash/aura/wm_window_aura.h
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/common/shelf/wm_shelf.cc
[rename] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/common/wm_window.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/common/wm_window.h
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/content/screen_orientation_delegate_chromeos.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/display/screen_ash.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/display/screen_position_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/drag_drop/drag_drop_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/drag_drop/drag_drop_tracker.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/drag_drop/drag_drop_tracker_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/high_contrast/high_contrast_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/bridge/wm_lookup_mus.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/disconnected_app_handler.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/move_event_handler.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/move_event_handler.h
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/non_client_frame_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/root_window_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/root_window_controller.h
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/test/ash_test_impl_mus.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/test/wm_test_base.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/test/wm_test_base.h
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/mus/window_manager.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/root_window_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/shelf/shelf_window_targeter.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/shell.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/shell/window_watcher.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/test/BUILD.gn
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/test/ash_test_impl_aura.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/test/ui_controls_factory_ash.cc
[delete] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ash/test/wm_window_aura_test_api.cc
[add] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/test/wm_window_test_api.cc
[rename] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/test/wm_window_test_api.h
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/always_on_top_controller_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/drag_window_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/drag_window_resizer.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/drag_window_resizer_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/overview/scoped_overview_animation_settings_factory_aura.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/panels/attached_panel_window_targeter.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/screen_dimmer_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/screen_pinning_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/screen_pinning_controller_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/stacking_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/system_gesture_event_filter_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/toplevel_window_event_handler.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/window_animations.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/window_mirror_view.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/window_mirror_view.h
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/window_state_aura.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/window_util.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/window_util_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/workspace/multi_window_resize_controller_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/workspace/workspace_event_handler_aura.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/chromeos/ui/accessibility_cursor_ring_layer.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/session_state_delegate_chromeos.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/ash/shelf_browsertest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/views/tabs/window_finder_ash.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/window_sizer/window_sizer_ash.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/components/exo/pointer_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/components/exo/shell_surface.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/components/exo/test/exo_test_helper.cc
[modify] https://crrev.com/5dbc91d59a8f1fbfd4987f8539ee032fe29481c3/components/exo/touch_unittest.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abcae81155dabe9d4c2a8cb7e39fc3c93157b703

commit abcae81155dabe9d4c2a8cb7e39fc3c93157b703
Author: sky <sky@chromium.org>
Date: Wed Jan 18 17:01:34 2017

Converts mash to use Shell

Shell has a bunch of stuff that is cash specific and or needs to be
made to work in mash. In hopes of not making a ginormous patch I'll do
cleanup later on.

BUG= 671246 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2633293005
Cr-Commit-Position: refs/heads/master@{#444401}

[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/DEPS
[add] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/aura/DEPS
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/common/wm_shell.cc
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/common/wm_shell.h
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/display/window_tree_host_manager.h
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/BUILD.gn
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/keyboard_ui_mus.cc
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/keyboard_ui_mus.h
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/root_window_controller.cc
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/window_manager.cc
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/window_manager.h
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/mus/window_manager_application.cc
[delete] https://crrev.com/dce92226064b936c993447a2eb30a0333b1a7848/ash/mus/window_manager_observer.h
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/root_window_controller.cc
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/root_window_controller.h
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/shell.cc
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/shell.h
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ash/shell_init_params.h
[modify] https://crrev.com/abcae81155dabe9d4c2a8cb7e39fc3c93157b703/ui/events/event_target.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3

commit 8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3
Author: sky <sky@chromium.org>
Date: Thu Jan 19 15:55:29 2017

Removes ash::mus::RootWindowController

The functionality is moved into two places:
. Maintaining the display goes to ScreenMus.
. Creating the window moves to top_level_window_factory.

As part of this I'm removing some functionality that staggered top
level windows. I suspect this isn't used much and needs some
changes. Will address this later.

BUG= 671246 
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2642003002
Cr-Commit-Position: refs/heads/master@{#444745}

[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/BUILD.gn
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/bridge/wm_lookup_mus.cc
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/bridge/wm_lookup_mus.h
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/bridge/wm_shell_mus.h
[delete] https://crrev.com/a1193bdc94a5163af5cd0a71bf438c44fa08fd16/ash/mus/root_window_controller.cc
[delete] https://crrev.com/a1193bdc94a5163af5cd0a71bf438c44fa08fd16/ash/mus/root_window_controller.h
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/screen_mus.cc
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/screen_mus.h
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/test/wm_test_base.cc
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/test/wm_test_helper.h
[add] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/top_level_window_factory.cc
[add] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/top_level_window_factory.h
[rename] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/top_level_window_factory_unittest.cc
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/window_manager.cc
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/mus/window_manager.h
[modify] https://crrev.com/8a8ffd21bdd7e290cbe4587b64471d13e7bb40c3/ash/root_window_controller.h

Comment 19 by sky@chromium.org, Feb 1 2017

Summary: Minimize ash porting layer (was: Figure out right structure for classic aura and aura-mus porting layer)
I'm changing the title of this to better reflect what should happen. There still needs to be a porting layer, but it's very minimal. Most likely WmShellMus and WmShellAura are all that's needed.

Comment 20 by sky@chromium.org, Feb 1 2017

Blockedon: 687649

Comment 21 by sky@chromium.org, Feb 1 2017

Blockedon: 687654

Comment 22 by sky@chromium.org, Feb 1 2017

Blockedon: 687656

Comment 23 by sky@chromium.org, Feb 1 2017

Blockedon: 687657

Comment 24 by sky@chromium.org, Feb 1 2017

Blockedon: 687658

Comment 25 by sky@chromium.org, Feb 1 2017

Blockedon: 687660

Comment 26 by sky@chromium.org, Feb 1 2017

Blockedon: 687662

Comment 27 by sky@chromium.org, Feb 1 2017

Blockedon: 687663

Comment 28 by sky@chromium.org, Feb 1 2017

Blockedon: 687664
Blockedon: 690096
Blockedon: 666778

Comment 32 by sky@chromium.org, Mar 7 2017

Blockedon: 699231

Comment 33 by sky@chromium.org, Mar 8 2017

Blockedon: 699678

Comment 34 by sky@chromium.org, Mar 23 2017

Blockedon: 704615

Comment 35 by sky@chromium.org, Mar 27 2017

Labels: mustash-2

Comment 36 by sky@chromium.org, Mar 31 2017

Blockedon: -687664

Comment 37 by sky@chromium.org, Apr 18 2017

Blockedon: 707057
Project Member

Comment 38 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00f0b896b1fea3226f9cbbdfd592edc39b49f158

commit 00f0b896b1fea3226f9cbbdfd592edc39b49f158
Author: sky <sky@chromium.org>
Date: Fri May 05 17:06:24 2017

chromeos: gets rid of wm_screen_util

And folds implementation back into ash/screen_util.

BUG= 671246 
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2860163005
Cr-Commit-Position: refs/heads/master@{#469687}

[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/BUILD.gn
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/root_window_controller.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/screen_util.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/screen_util.h
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/screen_util_unittest.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/default_state.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/lock_window_state.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/window_positioner.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/window_positioning_utils.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/window_state.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/window_util.cc
[delete] https://crrev.com/bf1b5296ef441a71980bd48279c4442cb53957fd/ash/wm/wm_screen_util.cc
[delete] https://crrev.com/bf1b5296ef441a71980bd48279c4442cb53957fd/ash/wm/wm_screen_util.h
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/00f0b896b1fea3226f9cbbdfd592edc39b49f158/ash/wm/workspace/workspace_window_resizer.cc

Blockedon: 725990
Project Member

Comment 40 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3301607c94a89ec896e7c33f0ec1612e995e84e

commit c3301607c94a89ec896e7c33f0ec1612e995e84e
Author: jamescook <jamescook@chromium.org>
Date: Tue May 30 21:49:28 2017

chromeos: Remove TrayBubbleView::Delegate::OnBeforeBubbleWidgetInit

This method was added to let mash set the widget container back when
mash could not use aura::Window. Now we can set the parent aura::Window
explicitly.

Eliminate the TrayBubbleView::Create() factory method because its
signature is identical to the constructor and it doesn't do any
validation.

Eliminate some GetInitParams / GetDefaultInitParams methods that were
only used by WebNotificationTray.

This is mostly a manual revert of:
https://codereview.chromium.org/2092473002/

BUG= 671246 
TEST=ash_unittests, views_unittests, manually opening all system tray
bubbles on primary and secondary monitors

Review-Url: https://codereview.chromium.org/2901273003
Cr-Commit-Position: refs/heads/master@{#475682}

[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ash/system/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ash/system/palette/palette_tray.h
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ash/system/tray/system_tray.cc
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ash/system/tray/system_tray.h
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ash/system/tray/tray_background_view.h
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ui/message_center/views/message_bubble_base.cc
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ui/message_center/views/message_bubble_base.h
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ui/message_center/views/message_center_bubble.cc
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ui/message_center/views/message_center_bubble.h
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ui/views/bubble/bubble_dialog_delegate.h
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/c3301607c94a89ec896e7c33f0ec1612e995e84e/ui/views/bubble/tray_bubble_view.h

Project Member

Comment 41 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41562d1c4dd2020f00178e708e562894806d16ef

commit 41562d1c4dd2020f00178e708e562894806d16ef
Author: Scott Violet <sky@chromium.org>
Date: Mon Jun 26 15:45:18 2017

chromeos: moves metrics function back onto metrics classes

The plan for metrics is to make all the histogram macros and what not
redirect to a service as appropriate. So, this means we can nuke the
calls to ShellPort and instead call directly to the metrics classes.

BUG= 671246 
TEST=none

Change-Id: I8fa7e45f48b20815e1afeb911bd876f19abffbfc
Reviewed-on: https://chromium-review.googlesource.com/546845
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482284}
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/accelerators/exit_warning_handler.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/aura/shell_port_classic.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/aura/shell_port_classic.h
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/frame/caption_buttons/frame_size_button.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/metrics/desktop_task_switch_metric_recorder.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/mus/bridge/shell_port_mash.h
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/shelf/shelf_alignment_menu.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/shelf/shelf_button_pressed_metric_tracker.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/shelf/shelf_view.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/shell.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/shell_port.h
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/audio/volume_view.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/brightness/tray_brightness.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/ime_menu/ime_list_view.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/keyboard_brightness_controller.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/network/network_list.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/network/tray_network.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/network/tray_vpn.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/network/vpn_list_view.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/screen_security/screen_capture_tray_item.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/tiles/tiles_default_view.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/tray/system_tray.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/tray_accessibility.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/tray_caps_lock.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/tray_tracing.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/update/tray_update.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/system/user/user_view.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/touch/touch_uma.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/wm/gestures/overview_gesture_handler.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/wm/maximize_mode/maximize_mode_controller.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/wm/panels/panel_window_event_handler.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/wm/window_cycle_controller.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/wm/workspace/workspace_event_handler.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/41562d1c4dd2020f00178e708e562894806d16ef/chrome/browser/ui/ash/launcher/launcher_context_menu.cc

Comment 42 by sky@chromium.org, Jun 26 2017

Status: Fixed (was: Started)

Comment 43 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment