New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671242 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Email to this user bounced
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 670455



Sign in to add a comment

Define whether orientation lock when video is fullscreen'd should apply to WebView

Project Member Reported by mlamouri@chromium.org, Dec 5 2016

Issue description

timav@ and torne@, can you give use feedback wrt to whether the feature in bug 670455 should apply to WebView. The implementation will be for OS_ANDROID and unless we hear back from you it will stay as is so please let us know if you want us to make a special case of WebView here :)
 

Comment 1 by ti...@chromium.org, Dec 5 2016

Cc: sgu...@chromium.org
I think that proposed feature makes sense for WebView as well (in other words, I do not see what would block it). I'm not sure whether we want to lock the screen without the user (i.e. a third-party Android developer) consent, in that case yet another entry in WebSettings
https://developer.android.com/reference/android/webkit/WebSettings.html
might be needed.

Comment 3 by torne@chromium.org, Dec 7 2016

Tima, if you think the developer needs to be able to control the behaviour then that means we *do* need to block this for WebView. There's two ways we usually allow developers to control behaviours like this:

1) Have the feature be disabled by default and introduce an API that turns it on in the next version of Android.
2) Have the feature be disabled by default unless the app's targetSDKVersion is "the next version of Android", and introduce an API that turns it *off* in the next version of Android.

In both cases, the "immediate" behaviour for existing apps and OS versions would be that the feature is disabled, and so the first step is to entirely disable the feature for WebView until we've implemented one or the other of those two options.

Of course, sometimes we decide that it's not necessary for the developer to control the behaviour at all, and we simply enable it unconditionally, and that's fine if we believe the compatibility risk is low. But, what we avoid is "add an API to control it in the next version of android, but have it enabled by default for all apps", because that doesn't really make sense; either it's a compatibility risk or it's not.

Comment 4 by ti...@chromium.org, Dec 7 2016

Torne, thank you, makes perfect sense!
Personally I like the safest option, which is (1): disable everywhere and let the user enable it with the new API. They can only do it in a new version, where such API would exist.

However, this is based on my conservative personality and not on any specific technical differences between video in Chrome vs WebView.

Comment 5 by ti...@chromium.org, Jan 12 2017

Cc: mlamouri@chromium.org
Mounir, Torne, would you like to add something? Or shall I close this bug?
Status: WontFix (was: Assigned)
Because screen orientation api is disabled on WebView, there is nothing specific to do here: the feature will automatically not work.

Sign in to add a comment