Touch rects aren't updated when touch event feature detection is disabled |
|||
Issue descriptionScrollingCoordinator::updateTouchEventTargetRectsIfNeeded() currently doesn't update the touch rects when TouchEvent feature detection is disabled. This could bad scrolling with a touch-action:none region. Always updating the rects should correct the problem but could be bad for scrolling performance.
,
Dec 6 2016
I personally would go with 1. I prefer consistency and yes we are debating about doing this on *desktop* platforms and we already are doing it on mobile platforms. Granted the page set could be different but my guess is that we likely won't notice it.
,
Dec 6 2016
Yeah, I favor option 1 as well.
,
Dec 6 2016
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4436064358a762936f8da853fc1271e036b96491 commit 4436064358a762936f8da853fc1271e036b96491 Author: sunyunjia <sunyunjia@chromium.org> Date: Thu Dec 15 18:15:56 2016 Remove all refs to touchEventFeatureDetection in ScrollingCoordinator. ScrollingCoordinator::updateTouchEventTargetRectsIfNeeded() currently doesn't update the touch rects when TouchEvent feature detection is disabled. This could be bad when scrolling with a touch-action:none region. Since we are always firing touch events, we can remove all refs to touchEventFeatureDetection in ScrollingCoordinator. BUG= 671232 Review-Url: https://codereview.chromium.org/2582473003 Cr-Commit-Position: refs/heads/master@{#438875} [modify] https://crrev.com/4436064358a762936f8da853fc1271e036b96491/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
,
Dec 15 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rbyers@chromium.org
, Dec 6 2016Cc: sunyunjia@chromium.org aelias@chromium.org
Summary: Touch rects aren't updated when touch event feature detection is disabled (was: Update touch rects regardless of the touch event flag)