New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671226 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Record user actions when the screen orientation has changed

Project Member Reported by mlamouri@chromium.org, Dec 5 2016

Issue description

Record user actions when the screen orientation changes. It would help us figure out the relationship between fullscreen and screen orientation change.

I think this should probably be done in the browser process in the code that notifies content when the display has rotated.
 
Did you mean "Record user actions" in the title? I'm a bit confused :)
Summary: Record user actions when the screen orientation has changed (was: Add user actions when the screen orientation has changed)
Yes :)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/551bf496b3e6c42e573faf76dc64414d20e3bcbb

commit 551bf496b3e6c42e573faf76dc64414d20e3bcbb
Author: zqzhang <zqzhang@chromium.org>
Date: Wed Dec 07 19:29:32 2016

Record user action of screen orientation change

In this CL, we record user action when the screen orientation has
changed. The purpose of this recording is to study the relationship
between fullscreen and screen orientation change.

BUG= 671226 

Review-Url: https://codereview.chromium.org/2559463002
Cr-Commit-Position: refs/heads/master@{#437030}

[modify] https://crrev.com/551bf496b3e6c42e573faf76dc64414d20e3bcbb/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/551bf496b3e6c42e573faf76dc64414d20e3bcbb/tools/metrics/actions/actions.xml

Labels: -OS-All OS-Android
Labels: Merge-Request-56

Comment 6 by dimu@chromium.org, Dec 7 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 8 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23d99b0a145aac9409b38b1234135aee39e5ea97

commit 23d99b0a145aac9409b38b1234135aee39e5ea97
Author: Zhiqiang Zhang <zqzhang@google.com>
Date: Thu Dec 08 15:55:35 2016

Record user action of screen orientation change

In this CL, we record user action when the screen orientation has
changed. The purpose of this recording is to study the relationship
between fullscreen and screen orientation change.

BUG= 671226 

Review-Url: https://codereview.chromium.org/2559463002
Cr-Commit-Position: refs/heads/master@{#437030}
(cherry picked from commit 551bf496b3e6c42e573faf76dc64414d20e3bcbb)

Review URL: https://codereview.chromium.org/2558323002 .

Cr-Commit-Position: refs/branch-heads/2924@{#405}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/23d99b0a145aac9409b38b1234135aee39e5ea97/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/23d99b0a145aac9409b38b1234135aee39e5ea97/tools/metrics/actions/actions.xml

Status: Fixed (was: Assigned)

Sign in to add a comment