Enable Cardboard support on Daydream device |
||||||||||||
Issue descriptionIt looks like there is a workaround for Cardboard support for our ChromeTabbedActivity. We just need to manually check if the current viewer type is Daydream or not and then use different code path to decide if DON is necessary. This workaround restrict to Daydream ready device though.
,
Dec 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5e72ebfb73d97c2d7175d2fb578c48006b66c22 commit f5e72ebfb73d97c2d7175d2fb578c48006b66c22 Author: bshe <bshe@chromium.org> Date: Mon Dec 05 21:44:25 2016 Enable Cardboard support on Daydream ready device BUG= 671224 Review-Url: https://codereview.chromium.org/2547973002 Cr-Commit-Position: refs/heads/master@{#436420} [modify] https://crrev.com/f5e72ebfb73d97c2d7175d2fb578c48006b66c22/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/f5e72ebfb73d97c2d7175d2fb578c48006b66c22/chrome/browser/android/vr_shell/vr_shell_delegate.cc
,
Dec 5 2016
,
Dec 5 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 5 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca4176715d4e0159beec6d08d8420c19e2c7b4f8 commit ca4176715d4e0159beec6d08d8420c19e2c7b4f8 Author: bshe <bshe@chromium.org> Date: Wed Dec 07 21:17:24 2016 Enable Cardboard support on Daydream ready device BUG= 671224 Review-Url: https://codereview.chromium.org/2547973002 Cr-Commit-Position: refs/heads/master@{#436420} (cherry picked from commit f5e72ebfb73d97c2d7175d2fb578c48006b66c22) Review URL: https://codereview.chromium.org/2548363009 . Cr-Commit-Position: refs/branch-heads/2924@{#388} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/ca4176715d4e0159beec6d08d8420c19e2c7b4f8/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/ca4176715d4e0159beec6d08d8420c19e2c7b4f8/chrome/browser/android/vr_shell/vr_shell_delegate.cc
,
Dec 7 2016
,
Jan 19 2017
,
Jul 7 2017
,
Jul 7 2017
,
Jul 13 2017
,
Jul 4
,
Jul 4
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by bshe@chromium.org
, Dec 5 2016