New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671206 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 624436
issue 369849



Sign in to add a comment

"depth_capture_tests (with patch)" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 5 2016

Issue description

"depth_capture_tests (with patch)" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBkZXB0aF9jYXB0dXJlX3Rlc3RzICh3aXRoIHBhdGNoKQw.


 

Comment 1 by hbos@chromium.org, Dec 5 2016

Labels: -Sheriff-Chromium
Owner: aleksand...@intel.com
Status: Assigned (was: Untriaged)
Can you please take a look aleksandar.stojiljkovic?
Was this caused by https://codereview.chromium.org/2476693002 ? (Recent change to DepthCapture depthStreamToRGBAFloatTexture)
Status: Started (was: Assigned)

Comment 3 Deleted

2 failures in the last 200 cases, all seem to fail on ati gpu on mac retina:

Failed steps failed depth_capture_tests on ati gpu on mac retina (with patch) failed depth_capture_tests on ati gpu on mac retina (retry summary)

Thanks. Working on it.
This should be a workaround until the issues is resolved:
https://codereview.chromium.org/2550193002/
This is related to modulo of negative number.  It wasn't noticed before as it happens only when the time between fake capture start and getting the first frame is > 2.5s (see kGradientFrequency = 1.f / 5 in fake_video_capture_device.cc).
Proper fix uploaded to https://codereview.chromium.org/2550193002/.


Comment 7 by kbr@chromium.org, Dec 5 2016

Blocking: 369849 624436
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aad17fb748c0e707ad71b6b054aa9d37120e44e

commit 4aad17fb748c0e707ad71b6b054aa9d37120e44e
Author: aleksandar.stojiljkovic <aleksandar.stojiljkovic@intel.com>
Date: Mon Dec 05 22:25:15 2016

Fix: DepthCapture_depthStreamToRGBAFloatTexture flaky on MAC ATI Retina

This is related to modulo of negative number.

BUG= 671206 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2550193002
Cr-Commit-Position: refs/heads/master@{#436425}

[modify] https://crrev.com/4aad17fb748c0e707ad71b6b054aa9d37120e44e/content/test/data/media/depth_stream_test_utilities.js

Status: Fixed (was: Started)

Sign in to add a comment