PushMessaging.UnregistrationReason UMA should count GCM Store resets |
|||||||
Issue descriptionCurrently the PushMessaging.UnregistrationReason histogram omits cases where we delete push subscriptions due to a GCM Store reset, since that happens not to call the Unsubscribe method. See https://crbug.com/642139#c34
,
Dec 7 2016
Requesting merge of 749c7daaa5a048b51d96b8bd2b4277ea3a54c252 to M56. Simple UMA addition that'll help understand errors better.
,
Dec 7 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4bec91c29aec1cd85b64bc70cfe089ac83fd5912 commit 4bec91c29aec1cd85b64bc70cfe089ac83fd5912 Author: John Mellor <johnme@chromium.org> Date: Wed Dec 07 19:45:25 2016 PushMessaging.UnregistrationReason UMA should count GCM Store resets BUG= 671203 Review-Url: https://codereview.chromium.org/2548393002 Cr-Commit-Position: refs/heads/master@{#437005} (cherry picked from commit 749c7daaa5a048b51d96b8bd2b4277ea3a54c252) Review URL: https://codereview.chromium.org/2562513002 . Cr-Commit-Position: refs/branch-heads/2924@{#386} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/4bec91c29aec1cd85b64bc70cfe089ac83fd5912/chrome/browser/push_messaging/push_messaging_service_impl.cc [modify] https://crrev.com/4bec91c29aec1cd85b64bc70cfe089ac83fd5912/content/public/common/push_messaging_status.h [modify] https://crrev.com/4bec91c29aec1cd85b64bc70cfe089ac83fd5912/tools/metrics/histograms/histograms.xml
,
Dec 7 2016
,
Dec 8 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 9 2016
***BULK EDIT*** Your change has been approved for M56. Please ensure to verify the fix and merge ASAP so that we could take it for next Beta Release. If the change is already merged and no pending work please remove Merge-Approved-56 label and add merge-merged-2924.
,
Dec 12 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 13 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Dec 7 2016