textdecoder-labels.html times out on WebKit Linux Trusty MSAN |
||||
Issue descriptionThe webkit_tests test imported/wpt/encoding/textdecoder-labels.html consistently fails on WebKit Linux Trusty MSAN, example: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/130 I have disabled it (https://codereview.chromium.org/2546383002). Not sure who to assign this to, the git blame'd joelo does not seem to have been active for a year. qyearsley can you take a look/triage?
,
Dec 6 2016
Hmm, in general I guess in this case it might be nicer to have the tests marked Slow if possible. Note: encoding/textdecoder-labels.html hasn't changed for some time; maybe it was close to the timeout before and the test runner was just running more slowly recently? The other test (http/tests/streams/writable-streams/write.https.html) was added recently in r430881, and there's no MSAN layout test CQ builder, so it's possible that it has always timed out on the MSAN bot?
,
Dec 6 2016
textdecoder-labels.html has 3392 tests; each one is a single assert but that might be tripping out MSAN even with its extra timeout. We can look at consolidating the tests upstream.
,
Dec 6 2016
Filed https://github.com/w3c/web-platform-tests/pull/4290 (I'm not sure why the test was structured as it was originally.)
,
Dec 6 2016
Excellent, thanks for making that. I also made a CL to mark them as slow (https://codereview.chromium.org/2554853003), but if https://github.com/w3c/web-platform-tests/pull/4290 is merged then likely textdecoder-labels.html shouldn't be marked as slow.
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/936ea4d1e08c58c6757396db4e3919dd64d9783c commit 936ea4d1e08c58c6757396db4e3919dd64d9783c Author: qyearsley <qyearsley@chromium.org> Date: Wed Dec 07 18:30:54 2016 Change expectations for three layout tests from Timeout Pass to Slow. Specifically: - imported/wpt/encoding/textdecoder-labels.html, and - http/tests/streams/writable-streams/write.https.html and related virtual test virtual/mojo-loading/http/tests/streams/writable-streams/write.https.html BUG= 671164 Review-Url: https://codereview.chromium.org/2554853003 Cr-Commit-Position: refs/heads/master@{#437014} [modify] https://crrev.com/936ea4d1e08c58c6757396db4e3919dd64d9783c/third_party/WebKit/LayoutTests/MSANExpectations [modify] https://crrev.com/936ea4d1e08c58c6757396db4e3919dd64d9783c/third_party/WebKit/LayoutTests/SlowTests
,
Dec 7 2016
Next step: Check to see if some tests fail on the MSAN bot (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN); if the tests still Timeout there, then some other action has to be taken, e.g. splitting up or debugging the tests. Also, I should check whether imported/wpt/encoding/textdecoder-labels.html is still slow after https://github.com/w3c/web-platform-tests/pull/4290.
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c06df626151088d15a0e134dbd7c49350d0f217 commit 2c06df626151088d15a0e134dbd7c49350d0f217 Author: qyearsley <qyearsley@chromium.org> Date: Fri Jan 20 18:58:04 2017 Remove wpt/encoding/textdecoder-labels.html from SlowTests. After https://github.com/w3c/web-platform-tests/pull/4290, I believe this test should no longer be slow. BUG= 671164 Review-Url: https://codereview.chromium.org/2646883002 Cr-Commit-Position: refs/heads/master@{#445112} [modify] https://crrev.com/2c06df626151088d15a0e134dbd7c49350d0f217/third_party/WebKit/LayoutTests/SlowTests
,
Jan 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by hbos@chromium.org
, Dec 5 2016