Rename "commit git patch" to "commit-git-patch" and mark it as known trooper flake |
||||||||||||
Issue description"commit" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyEQsSBUZsYWtlIgZjb21taXQM. This flaky test/step was previously tracked in issue 657318 .
,
Dec 5 2016
The CL is https://codereview.chromium.org/2513983002, which modifies two files. Stepan: maybe you could try uploading a new patchset to reitveld and submitting again? Adding Infra-Troopers label in case this is a bot problem.
,
Dec 5 2016
,
Dec 5 2016
It seems like one of the files moved, and the other had the same change as the CL in question, so git diff yielded an empty output. Trying to reupload as a new issue revealed this problem. Thanks! Not closing the bug because maybe a better error message can be added for this.
,
Dec 5 2016
+sergiyb@ This step should be excluded in flakiness.
,
Dec 8 2016
rational for exclusion proposal above: presubmit recipe commits the patch that has just been applied by bot_update. This normally doesn't fail, but consider what happens when a CL is committed right after presubmit tryjob is triggered s.t. bot_update fetches master branch *with* the CL already on it. Due the nature of Rietveld patch application logic, it's possible that patch might still "kinda" apply, yet there is actually no diff, hence git commit fails. Of course, ideally apply_issue is fixed, but given that we aim to kill rietveld, I propose to instead ignore "flakiness" in commit step.
,
Dec 8 2016
I see two issues here: 1) Bug report is confusingly named "commit". Unfortunately, due to limitations of the current system, we take first word by default. We can rename step to "commit-git-patch" and then it will be shown in full. I have filed an issue 672531 for better naming of the step on the bug. 2) Step "commit git patch" is flaky. I think we should keep this bug open since this is a flake. If we do not wish to fix code that is soon-to-be-deprecated, we need to reduce the priority of this bug. However, should the step become much more flaky, it should not be ignored and reported on this bug. Therefore: - adding Infra>Flakiness since this is infra flake - remove Tests>Flaky since this is not a test flake - CCing katthomas@ who works on burning down infra failures - CCing tandrii@ since he has needed context and can help fixing this issue if it becomes much more severe Please let me know if you still think there are good reasons for ignoring this flake.
,
Dec 9 2016
Agree with all of the above, and also removing from trooper queue.
,
Dec 14 2016
Detected 4 new flakes for test/step "commit". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyEQsSBUZsYWtlIgZjb21taXQM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Dec 14 2016
The CL is https://codereview.chromium.org/2551153003, seems like it's being landed multiple times. Failure is different to the previous in this bug, and I presume it's expected. Comment in the CL also says that a new CL has to be created, which confirms that.
,
Jan 6 2017
Detected 4 new flakes for test/step "commit". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyEQsSBUZsYWtlIgZjb21taXQM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jan 9 2017
Detected 6 new flakes for test/step "commit". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyEQsSBUZsYWtlIgZjb21taXQM. This message was posted automatically by the chromium-try-flakes app.
,
Jan 9 2017
CL to rename step: https://chromium-review.googlesource.com/c/426219/. CL to mark it as known trooper flake: https://chromium-review.googlesource.com/c/426320/. If the step is still flaky, a new bug will be created and assigned to troopers. I'll close this bug when 2 CLs above will land.
,
Jan 9 2017
,
Jan 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/732d7d9bcae5e52d2e501977d93c99069a75abf9 commit 732d7d9bcae5e52d2e501977d93c99069a75abf9 Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Mon Jan 09 15:47:50 2017 Rename step to show up correctly in bugs filed by Chromium Try Flakes BUG= 671161 Change-Id: Ie43e7a509953db8769d4254b353dc6fa2a6bc407 Reviewed-on: https://chromium-review.googlesource.com/426219 Reviewed-by: Emma Söderberg <emso@chromium.org> Commit-Queue: Sergiy Byelozyorov (OOO till Jan 8) <sergiyb@chromium.org> [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/build.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/build_internal.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/build_internal_scripts_slave.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/catapult.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/chrome_golo.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/chromium.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/chromium_dry_run.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/chromium_with_auth.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/depot_tools.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/gyp.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks_and_gerrit.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/internal_deps.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/master_deps.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/nacl.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/presubmit-failure.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/presubmit-infra-failure.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/recipes-py.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/repository_url.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/skia.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/slave_deps.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/v8.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/webports.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.expected/webrtc.json [modify] https://crrev.com/732d7d9bcae5e52d2e501977d93c99069a75abf9/scripts/slave/recipes/run_presubmit.py
,
Jan 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/5d82137130f3501da068e1eda027429a3f508a0e commit 5d82137130f3501da068e1eda027429a3f508a0e Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Mon Jan 09 15:50:04 2017 Mark commit-git-patch as a known trooper flake BUG= 671161 Change-Id: Iadd3c77fed8d7c47434b97042724c171f8112aa1 Reviewed-on: https://chromium-review.googlesource.com/426320 Reviewed-by: Emma Söderberg <emso@chromium.org> Commit-Queue: Sergiy Byelozyorov (OOO till Jan 8) <sergiyb@chromium.org> [modify] https://crrev.com/5d82137130f3501da068e1eda027429a3f508a0e/appengine/chromium_try_flakes/handlers/flake_issues.py
,
Jan 9 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by rogerta@chromium.org
, Dec 5 2016