New issue
Advanced search Search tips

Issue 671148 link

Starred by 1 user
Status: Fixed
Owner:
maxmorin@chromium.org
Closed: Dec 2016
Cc:
maxmorin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Use of uninitialized value in chromoting_test_driver_environment.cc

Project Member Reported by maxmorin@chromium.org, Dec 5 2016 
In Chrome ToT, causes msan failure (e.g. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_msan_rel_ng/builds/399/steps/remoting_unittests%20%28with%20patch%29/logs/ChromotingTestDriverEnvironmentTest.InitializeObjectWithAuthCode). The issue is that use_test_environment isn't initialized in the EnvironmentOptions constructor (it has an empty constructor).

Joedow: PTAL, this seems to be your code.

Comment 1 by joedow@chromium.org, Dec 5 2016

Components: Services>Chromoting
Status: Assigned (was: Untriaged)
Will get a fix for this in today.

Comment 2 by joedow@chromium.org, Dec 5 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7d28e6b514dba42d896091f51aafefe89a56195

commit b7d28e6b514dba42d896091f51aafefe89a56195
Author: joedow <joedow@chromium.org>
Date: Mon Dec 05 23:48:24 2016

Fixing uninitialized variable in CTD EnvironmentOptions struct

BUG= 671148 

Review-Url: https://codereview.chromium.org/2552863002
Cr-Commit-Position: refs/heads/master@{#436460}

[modify] https://crrev.com/b7d28e6b514dba42d896091f51aafefe89a56195/remoting/test/chromoting_test_driver_environment.h

Comment 4 by joedow@chromium.org, Dec 5 2016

Owner: maxmorin@chromium.org
Status: Fixed (was: Started)
►

Sign in to add a comment