New issue
Advanced search Search tips

Issue 671137 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Add Page Info Modal for offline URLs.

Project Member Reported by jif@chromium.org, Dec 5 2016

Issue description

Modal should offer possibility to reload pages.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/2001754005c5d1eed5496aeb01af8e530d623a7a

commit 2001754005c5d1eed5496aeb01af8e530d623a7a
Author: jif <jif@google.com>
Date: Mon Dec 05 15:47:30 2016

Is this fixed?

Comment 3 by jif@chromium.org, Dec 12 2016

Cc: gambard@chromium.org
Owner: olivierrobin@chromium.org
Status: Assigned (was: Started)
No.

WIP: https://chromereviews.googleplex.com/553817013/

I can't work on it ATM, I'm assigning the bug to you.
Components: UI>Browser>Bubbles>PageInfo
Is there a way I can test this?
At the moment, it is work in progress.
When it is submitted, you can press on the offline icon in the omnibox to display the view.
Labels: -Pri-3 Pri-2
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c7f83aa87578c22ae7ae8f6987928f367b305d9

commit 7c7f83aa87578c22ae7ae8f6987928f367b305d9
Author: olivierrobin <olivierrobin@chromium.org>
Date: Thu Dec 15 09:58:07 2016

Add page info strings for offline pages.

BUG= 671137 

Review-Url: https://codereview.chromium.org/2572773002
Cr-Commit-Position: refs/heads/master@{#438796}

[modify] https://crrev.com/7c7f83aa87578c22ae7ae8f6987928f367b305d9/ios/chrome/app/strings/ios_strings.grd

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/3ed248a210ce50c6396b09338852e0c02efb688e

commit 3ed248a210ce50c6396b09338852e0c02efb688e
Author: olivierrobin <olivierrobin@google.com>
Date: Fri Dec 16 16:29:16 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in 57.0.2977.0 canary,  iPhone 6 plus 10.2

Viewing Offline Version is reloaded when tapping on reload link.

Sign in to add a comment