Hyphens inserted by CSS hyphenation create gaps at end of lines in justified text
Reported by
m...@thomasbachem.com,
Dec 5 2016
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.35 Safari/537.36 Steps to reproduce the problem: See attached test case. What is the expected behavior? Both texts should be hyphenated "hyphenational-gorithm" and justified. What went wrong? Chrome shows a gap after the hyphen at the end of the line, Safari and Firefox work as intended. Did this work before? N/A Does this work in other browsers? Yes Chrome version: 55.0.2883.35 Channel: n/a OS Version: OS X 10.11.2 Flash Version: Shockwave Flash 23.0 r0 Might be related to issue 639223.
,
Dec 5 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b73086fba57f587b632d5c60c3e912317fa2613 commit 1b73086fba57f587b632d5c60c3e912317fa2613 Author: kojii <kojii@chromium.org> Date: Wed Dec 07 07:22:35 2016 Fix not to double count the widths of hyphens The widths of hyphens are added to BidiRun in LayoutBlockFlow, and should not be included in WordMeasurement. BUG= 671129 Review-Url: https://codereview.chromium.org/2548333004 Cr-Commit-Position: refs/heads/master@{#436886} [modify] https://crrev.com/1b73086fba57f587b632d5c60c3e912317fa2613/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/1b73086fba57f587b632d5c60c3e912317fa2613/third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-align-expected.html [add] https://crrev.com/1b73086fba57f587b632d5c60c3e912317fa2613/third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-align.html [modify] https://crrev.com/1b73086fba57f587b632d5c60c3e912317fa2613/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
,
Dec 10 2016
Fixed in today's Canary, it'd be greatly appreciated if you could check your pages.
,
Dec 10 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36abedc360f1cf489839caf254f7f0491bbd6a93 commit 36abedc360f1cf489839caf254f7f0491bbd6a93 Author: Koji Ishii <kojii@chromium.org> Date: Sat Dec 10 06:39:33 2016 Merge 2924: Fix not to double count the widths of hyphens The widths of hyphens are added to BidiRun in LayoutBlockFlow, and should not be included in WordMeasurement. BUG= 671129 Review-Url: https://codereview.chromium.org/2548333004 Cr-Commit-Position: refs/heads/master@{#436886} (cherry picked from commit 1b73086fba57f587b632d5c60c3e912317fa2613) Review-Url: https://codereview.chromium.org/2564263002 . Cr-Commit-Position: refs/branch-heads/2924@{#445} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/36abedc360f1cf489839caf254f7f0491bbd6a93/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/36abedc360f1cf489839caf254f7f0491bbd6a93/third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-align-expected.html [add] https://crrev.com/36abedc360f1cf489839caf254f7f0491bbd6a93/third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-align.html [modify] https://crrev.com/36abedc360f1cf489839caf254f7f0491bbd6a93/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
,
Dec 12 2016
As per the process. The fix is quite safe.
,
Dec 12 2016
[Automated comment] Request affecting a post-stable build (M55), manual review required.
,
Dec 14 2016
Verified the fix on Mac 10.12.1 using Chrome Beta #56.0.2924.28 as per the comment #0. Observed that both texts are hyphenated "hyphenational-gorithm" and justified as expected. Hence, the fix is working as expected. Attaching the screenshot for reference. Adding the verified labels. Thanks...!!
,
Dec 14 2016
While the fix is simple, this is a Pri-2 and M55 is already deployed to stable across all platforms, so we should wait for M56 on this. Rejecting merge, ping me if you have concerns. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ranjitkan@chromium.org
, Dec 5 2016