New issue
Advanced search Search tips

Issue 671100 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 667073



Sign in to add a comment

Expose the site engagement service to Java

Project Member Reported by dominickn@chromium.org, Dec 5 2016

Issue description

Implement a Java shim for site engagement. This is required to allow the app banner navigation heuristic to be removed - we need to be able to programmatically change the site engagement values to test app banners.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8723b73ef4c0e4c7b59aa655f7a5d0cccbd79f2

commit b8723b73ef4c0e4c7b59aa655f7a5d0cccbd79f2
Author: dominickn <dominickn@chromium.org>
Date: Mon Dec 12 06:42:47 2016

Expose the Site Engagement Service to Java.

This CL adds a Java-side interface to the Site Engagement Service, as
well as a basic integration test for the interface. This allows Java
code (particularly tests) to programatically adjust and retrieve the
score.

BUG= 671100 

Review-Url: https://codereview.chromium.org/2553013002
Cr-Commit-Position: refs/heads/master@{#437825}

[add] https://crrev.com/b8723b73ef4c0e4c7b59aa655f7a5d0cccbd79f2/chrome/android/java/src/org/chromium/chrome/browser/engagement/SiteEngagementService.java
[modify] https://crrev.com/b8723b73ef4c0e4c7b59aa655f7a5d0cccbd79f2/chrome/android/java_sources.gni
[add] https://crrev.com/b8723b73ef4c0e4c7b59aa655f7a5d0cccbd79f2/chrome/android/javatests/src/org/chromium/chrome/browser/engagement/SiteEngagementServiceTest.java
[modify] https://crrev.com/b8723b73ef4c0e4c7b59aa655f7a5d0cccbd79f2/chrome/browser/BUILD.gn
[modify] https://crrev.com/b8723b73ef4c0e4c7b59aa655f7a5d0cccbd79f2/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/b8723b73ef4c0e4c7b59aa655f7a5d0cccbd79f2/chrome/browser/engagement/site_engagement_service.cc
[modify] https://crrev.com/b8723b73ef4c0e4c7b59aa655f7a5d0cccbd79f2/chrome/browser/engagement/site_engagement_service.h
[add] https://crrev.com/b8723b73ef4c0e4c7b59aa655f7a5d0cccbd79f2/chrome/browser/engagement/site_engagement_service_android.cc
[add] https://crrev.com/b8723b73ef4c0e4c7b59aa655f7a5d0cccbd79f2/chrome/browser/engagement/site_engagement_service_android.h

Status: Fixed (was: Started)

Sign in to add a comment