[SPInvalidation] Check failed: *m_originalProperties->effect() == *objectProperties->effect() |
|||
Issue descriptionTht following tests crash because the check failure: virtual/spinvalidation/paint/invalidation/filter-on-html-element-with-fixed-position-child.html virtual/spinvalidation/paint/invalidation/reflection-redraw.html virtual/spinvalidation/paint/invalidation/scroll-fixed-reflected-layer.html The first one is about changed opacity (0.999xx -> 0.999yy). The other two are about changed sk_sp<SkImageFilter> image_filter_ field of reflection filter operations. I guess this is not an actual change, but we create another SkImageFilter containing the same image which is treated as different.
,
Dec 6 2016
According to bug 671605 , virtual/spinvalidation/paint/invalidation/compositing/opacity-between-absolute.html and virtual/spinvalidation/paint/invalidation/compositing/opacity-between-absolute2.html also flakily crash because of the same reason.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99fb9d010d8614d8090b916394e34b4b628a0753 commit 99fb9d010d8614d8090b916394e34b4b628a0753 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Tue Dec 06 18:48:18 2016 Update test expectations for two virtual/spinvalidatin tests BUG= 671097 TBR=pdr@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2549143006 Cr-Commit-Position: refs/heads/master@{#436661} [modify] https://crrev.com/99fb9d010d8614d8090b916394e34b4b628a0753/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 7 2016
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3e11fe44bc15048029e2093a428234f0da084d3 commit b3e11fe44bc15048029e2093a428234f0da084d3 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Fri Dec 09 04:47:23 2016 Fix paint property under-invalidation checking about reference filters Previously we checked equality of reference filters by comparing the pointers to SkImageFilters. This cause false-positive when we forced property update for under-invalidation checking. Now ignore reference filters when comparing effect nodes, and check for changes of filter operations defined in style to remedy the ignored check. An alternative way is to add value equality operators in SkImageFilter subclasses, but that seems to need more code and time than this CL. We might make that a long-term objective. BUG= 671097 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2556013002 Cr-Commit-Position: refs/heads/master@{#437470} [modify] https://crrev.com/b3e11fe44bc15048029e2093a428234f0da084d3/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/b3e11fe44bc15048029e2093a428234f0da084d3/third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp [modify] https://crrev.com/b3e11fe44bc15048029e2093a428234f0da084d3/third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.h [modify] https://crrev.com/b3e11fe44bc15048029e2093a428234f0da084d3/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h
,
Dec 9 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wangxianzhu@chromium.org
, Dec 6 2016