New issue
Advanced search Search tips

Issue 671095 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
M-X

Blocked on:
issue 671082


Participants' hotlists:
MacViews-Task-Queue


Sign in to add a comment

MacViews: Ditch sheets

Project Member Reported by tapted@chromium.org, Dec 5 2016

Issue description

Chrome Version       : 56.0.2914.3
OS Version: OS X 10.12.1


Window-Modal sheets probably don't fit into the proposed tab-closable modality behaviours.

However, they're not that easy to get rid of.

One issue is window resize of the dialog. Resizing a sheet resizes it *and* repositions it. We need to hook into the mouse events somehow. It's not feasible just to observe for a window resize in the normal way because repositioning it will move the window under the mouse and immediately want the window to be resized again.

A fix for this might be to simply disable the ability to resize dialogs, the way it's done on other views platforms..

The rest is fairly straightforward.
 - WebContentsModalDialogHostCocoa needs to be fleshed out - it's missing a lot of functionality
  - alternatively, auto-convert everything to WebModal and "assume" we can always get a WebContents (or have a graceful fallback)
 - CreateBrowserModalDialogViews() should opt in to 'requires_positioning`
 - a bit of refactoring fallout.

WIP in https://codereview.chromium.org/2551773002 gets most of the way there.


 
Blockedon: 671082

Comment 2 by ajha@chromium.org, Dec 5 2016

Labels: M-56
Cc: tapted@chromium.org
Labels: -M-56 MacViews-Dialogs
tapted@: where are we on this?

Comment 4 by tapted@chromium.org, Apr 13 2017

Harmony "Phase 2" is changing modality behaviours. It doesn't include "window modal", so sheets will disappear as part of that. In the meantime, sheets still give the best UX for implementing window modal on Mac.
Labels: MacViews-Browser M-X
I'm going to tag this M-X (since we have no target fix date) and MacViews-Browser (since we do not need to fix it before MacViews launch).
Components: Internals>Views
Mac triage: this is still M-X; we don't know what the new modality behaviors are yet or have any concrete plans to work on them soon.
Labels: Group-Architecture
Owner: pbos@chromium.org
Status: Assigned (was: Available)
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIToolingRequired
**UI Mass Triage**

Adding labels for expert review.

Sign in to add a comment