Issue metadata
Sign in to add a comment
|
Stop Casting button in status bar should specify $media $device |
||||||||||||||||||||||||
Issue descriptionMode: force_next Version: 57.0.2940.0 Reproduction Steps: 1. Cast $media to $device 2. Alt+Shift+S for status tray > TAB to Stop button 3. Search+Left Arrow will utter "Casting $media to $device" Observed: Stop button Expected: Stop Casting $media to $device
,
Dec 5 2016
@Laura: could you help find owner? Thanks!
,
Jan 12 2017
One way of finding an owner is to see who's touched something similar in the codebase. For example, searching on crbug, I found: https://bugs.chromium.org/p/chromium/issues/detail?id=489445 I would try the owner of that bug. + cc jdufault@chromium.org for any help with this. Thanks!
,
Jan 12 2017
I'll try to take a look soon. Should be a relatively simple fix.
,
Jan 27 2017
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e949b4732c4d76670a39719a73422ed0dc2976c commit 4e949b4732c4d76670a39719a73422ed0dc2976c Author: jdufault <jdufault@chromium.org> Date: Mon Jan 30 20:07:58 2017 cros: Fix various small issues with cast tray entry. 673023: Do not show TrayCast active state until we have media router information to prevent short visual glitch where we are "Casting to unknown receiver". 683908: Only show local routes 671094: Better accessibility label for Stop casting button. BUG=673023, 683908 , 671094 Review-Url: https://codereview.chromium.org/2656003006 Cr-Commit-Position: refs/heads/master@{#447045} [modify] https://crrev.com/4e949b4732c4d76670a39719a73422ed0dc2976c/ash/ash_strings.grd [modify] https://crrev.com/4e949b4732c4d76670a39719a73422ed0dc2976c/ash/common/system/chromeos/cast/tray_cast.cc [modify] https://crrev.com/4e949b4732c4d76670a39719a73422ed0dc2976c/ash/common/system/chromeos/screen_security/screen_tray_item.h [modify] https://crrev.com/4e949b4732c4d76670a39719a73422ed0dc2976c/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
,
Jan 30 2017
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dbca8ec13dcf78b1c689018527315856c2b0a95 commit 1dbca8ec13dcf78b1c689018527315856c2b0a95 Author: Jacob Dufault <jdufault@google.com> Date: Thu Feb 16 19:13:02 2017 cros: Fix various small issues with cast tray entry. 673023: Do not show TrayCast active state until we have media router information to prevent short visual glitch where we are "Casting to unknown receiver". 683908: Only show local routes 671094: Better accessibility label for Stop casting button. BUG=673023, 683908 , 671094 Review-Url: https://codereview.chromium.org/2656003006 Cr-Commit-Position: refs/heads/master@{#447045} (cherry picked from commit 461840ed16b4e886966d5bc44558668f8df382b7) Review-Url: https://codereview.chromium.org/2697363002 . Cr-Commit-Position: refs/branch-heads/2987@{#553} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/1dbca8ec13dcf78b1c689018527315856c2b0a95/ash/ash_strings.grd [modify] https://crrev.com/1dbca8ec13dcf78b1c689018527315856c2b0a95/ash/common/system/chromeos/cast/tray_cast.cc [modify] https://crrev.com/1dbca8ec13dcf78b1c689018527315856c2b0a95/ash/common/system/chromeos/screen_security/screen_tray_item.h [modify] https://crrev.com/1dbca8ec13dcf78b1c689018527315856c2b0a95/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
,
Apr 17 2017
,
May 30 2017
,
Jul 10 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtseng@chromium.org
, Dec 5 2016