Issue metadata
Sign in to add a comment
|
8.2%-15.3% regression in smoothness.tough_path_rendering_cases at 435817:435947 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Dec 5 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8994156488409621808
,
Dec 5 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Remove the wrong optimization in replacing a text node with innerHTML Author : hayato Commit description: Replacing a single text node with innerHTML optimizes its behavior; it does not use a normal DOM mutation function. See `replaceChildrenWithFragment()` in Serialization.cpp for details. This optimization is wrong: <div>original</div> var originalText = div.firstChild; div.innerHTML = 'updated'; console.log(originalText.data); // It should show "original", but shows "updated". In addition to this wrong behavior, this optimization also: - Prevents a slotchange event from being fired because it skips the check. - Prevents a mutation observer from being notified. BUG= 658605 Review-Url: https://codereview.chromium.org/2532393003 Cr-Commit-Position: refs/heads/master@{#435908} Commit : 946f30141fad7e002a44d3545a7d9f45e3cdcbf3 Date : Fri Dec 02 10:46:28 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@435897 61.2398 2498.96 2327 good chromium@435903 60.9503 2502.56 2336 good chromium@435906 61.6182 2480.02 2313 good chromium@435907 61.7051 2478.71 2308 good chromium@435908 70.862 2329.13 2009 bad <-- Bisect job ran on: android_one_perf_bisect Bug ID: 671060 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests smoothness.tough_path_rendering_cases Test Metric: frame_times/frame_times Relative Change: 15.71% Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1847 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8994156488409621808 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=6186906109345792 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by qyears...@chromium.org
, Dec 5 2016