Add multiline support to RenderText::GetDecoratedWordAtPoint. |
||||
Issue descriptionAdd multiline support to RenderText::GetDecoratedWordAtPoint.
,
Jan 17 2017
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/666e4f0298298427d2026c2896466951f199f5bf commit 666e4f0298298427d2026c2896466951f199f5bf Author: karandeepb <karandeepb@chromium.org> Date: Mon Jan 23 01:57:27 2017 MacViews: Enable word lookup for selectable views::Labels and multi-line text. r423419 added support for word lookups to textfields on MacViews and r441290 added support for multi-line text selection to RenderTextHarfBuzz. This CL enables word lookup for selectable views::Labels. Changes: - Made views::Label inherit from WordLookupClient. - Moved GetLineContainingYCoord and GetLineSegmentContainingXCoord from RenderTextHarfBuzz to the base RenderText class. - Added multi-line support to RenderText::GetDecoratedWordAtPoint. BUG= 640502 , 671055 TEST=Run out/Default/views_examples_with_content_exe with the flag --enable- harfbuzz-rendertext. Go to the Label section. Ensure word lookup works correctly on pressing Ctrl+Command+D for selectable labels. Review-Url: https://codereview.chromium.org/2639493002 Cr-Commit-Position: refs/heads/master@{#445313} [modify] https://crrev.com/666e4f0298298427d2026c2896466951f199f5bf/ui/gfx/render_text.cc [modify] https://crrev.com/666e4f0298298427d2026c2896466951f199f5bf/ui/gfx/render_text.h [modify] https://crrev.com/666e4f0298298427d2026c2896466951f199f5bf/ui/gfx/render_text_harfbuzz.cc [modify] https://crrev.com/666e4f0298298427d2026c2896466951f199f5bf/ui/gfx/render_text_harfbuzz.h [modify] https://crrev.com/666e4f0298298427d2026c2896466951f199f5bf/ui/gfx/render_text_unittest.cc [modify] https://crrev.com/666e4f0298298427d2026c2896466951f199f5bf/ui/views/controls/label.cc [modify] https://crrev.com/666e4f0298298427d2026c2896466951f199f5bf/ui/views/controls/label.h
,
Jan 23 2017
,
Jan 23 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by karandeepb@chromium.org
, Dec 19 2016