New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671052 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 596786
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Security-UX

Blocking:
issue 606138



Sign in to add a comment

Add tests for PermissionPromptAndroid and GroupdPermissionInfobar

Project Member Reported by lshang@chromium.org, Dec 5 2016

Issue description

To make sure that reusing PermissionRequestManager won't crash anything.


 

Comment 1 by ajha@chromium.org, Dec 5 2016

Components: UI>Browser>Permissions>Prompts
Labels: M-57 OS-Android
Labels: -M-57
Owner: timloh@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/746d11013697cfc620b5a1dfcf76a745dfa5182d

commit 746d11013697cfc620b5a1dfcf76a745dfa5182d
Author: timloh <timloh@chromium.org>
Date: Mon May 22 02:24:04 2017

Test PermissionRequestManager on Android in GeolocationPermissionContext unit tests

This patch adds tests for the PermissionRequestManager on Android in the
GeolocationPermissionContext unit tests via testing::WithParamInterface.
The existing tests are refactored slightly to make this possible. In
particular, the #ifs which switched between checking the PRM and the
InfoBarService are replaced with checks on GetParam(), and as much as
possible this logic is pulled into AcceptPrompt() and so on.

BUG= 671052 ,  606138 

Review-Url: https://codereview.chromium.org/2876993003
Cr-Commit-Position: refs/heads/master@{#473491}

[modify] https://crrev.com/746d11013697cfc620b5a1dfcf76a745dfa5182d/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Comment 4 by raymes@chromium.org, Jun 22 2017

Mergedinto: 596786
Status: Duplicate (was: Assigned)

Comment 5 by raymes@chromium.org, Jun 22 2017

Status: Assigned (was: Duplicate)

Comment 6 by timloh@chromium.org, Jun 22 2017

Status: Fixed (was: Assigned)
PRM tests are being run on Android now, https://codereview.chromium.org/2917343002. Where relevant (e.g. comment #3 and a couple other patches), tests have been updated to use the PRM. Some of the GroupedPermissionInfoBar stuff has been removed so it's mostly just using the existing permission infobar code now.

Sign in to add a comment