Issue metadata
Sign in to add a comment
|
Add tests for PermissionPromptAndroid and GroupdPermissionInfobar |
||||||||||||||||||||||||||
Issue descriptionTo make sure that reusing PermissionRequestManager won't crash anything.
,
Mar 14 2017
,
May 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/746d11013697cfc620b5a1dfcf76a745dfa5182d commit 746d11013697cfc620b5a1dfcf76a745dfa5182d Author: timloh <timloh@chromium.org> Date: Mon May 22 02:24:04 2017 Test PermissionRequestManager on Android in GeolocationPermissionContext unit tests This patch adds tests for the PermissionRequestManager on Android in the GeolocationPermissionContext unit tests via testing::WithParamInterface. The existing tests are refactored slightly to make this possible. In particular, the #ifs which switched between checking the PRM and the InfoBarService are replaced with checks on GetParam(), and as much as possible this logic is pulled into AcceptPrompt() and so on. BUG= 671052 , 606138 Review-Url: https://codereview.chromium.org/2876993003 Cr-Commit-Position: refs/heads/master@{#473491} [modify] https://crrev.com/746d11013697cfc620b5a1dfcf76a745dfa5182d/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
,
Jun 22 2017
,
Jun 22 2017
,
Jun 22 2017
PRM tests are being run on Android now, https://codereview.chromium.org/2917343002. Where relevant (e.g. comment #3 and a couple other patches), tests have been updated to use the PRM. Some of the GroupedPermissionInfoBar stuff has been removed so it's mostly just using the existing permission infobar code now. |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Dec 5 2016Labels: M-57 OS-Android