New issue
Advanced search Search tips

Issue 671032 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner: ----
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

18.9%-312.7% regression in blink_perf.shadow_dom at 435444:435589

Project Member Reported by qyears...@chromium.org, Dec 4 2016

Issue description

See the link to graphs below.
 

===== BISECT JOB RESULTS =====
Status: failed


=== Bisection aborted ===
The bisect was aborted because Bisect cannot identify a culprit: Bisect failed to reproduce the regression with enough confidence.
Please contact the the team (see below) if you believe this is in error.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@435536  113.567  275.861  25  good
chromium@435569  114.535  279.113  25  bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 671032

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.shadow_dom
Test Metric: shadow-style-share-with-distribution/shadow-style-share-with-distribution
Relative Change: 0.85%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1241
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8994181270311495792


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5787918008844288

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Mergedinto: 670325
Status: Duplicate (was: Untriaged)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Detect floats to avoid or clear due to negative margin top
Author  : robhogan
Commit description:
  
When a negative margin top pushes a block back up into its previous siblings
we need to check for any floats in those siblings it now needs to avoid or clear.

Previously we were just looking at its neighbour, we need to keep looking until
we reach a sibling that we don't overlap.

BUG= 666487 

Review-Url: https://codereview.chromium.org/2531953002
Cr-Commit-Position: refs/heads/master@{#435497}
Commit  : 3c8d298acf826fc5337c526b1016a03b37c2656a
Date    : Thu Dec 01 00:42:03 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@435468  70.8798  27.4305  25  good
chromium@435494  70.8056  37.7519  25  good
chromium@435496  68.7576  28.2779  25  good
chromium@435497  177.074  440.802  25  bad    <--
chromium@435498  176.046  443.503  25  bad
chromium@435501  176.926  444.589  25  bad
chromium@435507  180.438  457.71   25  bad
chromium@435519  177.408  443.072  25  bad
chromium@435569  178.677  445.038  25  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 671032

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.shadow_dom
Test Metric: shadow-style-share-with-distribution/shadow-style-share-with-distribution
Relative Change: 152.08%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/901
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8994155791821585936


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6058897830313984

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment