New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671021 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 454858
issue 637203



Sign in to add a comment

angle_deqp_libgles3 build broken on chromium.gpu.fyi waterfall

Project Member Reported by kbr@chromium.org, Dec 4 2016

Issue description

The recent upgrade of the Windows compiler broke the build of existing targets on the chromium.gpu.fyi waterfall:

[3183/31079] CXX obj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj
FAILED: obj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj 
ninja -t msvc -e environment.x86 -- E:\b\c\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj.rsp /c ../../third_party/deqp/src/modules/gles3/performance/es3pBufferDataUploadTests.cpp /Foobj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj /Fd"obj/third_party/angle/src/tests/angle_deqp_libgles3_cc.pdb"
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): error C2220: warning treated as error - no 'object' file generated
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): warning C4828: The file contains a character starting at offset 0x3714f that is illegal in the current source character set (codepage 65001).
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings


Broken by a53f3c3734ad9ee4322f6a9a60eede7f6b04530f .

Need to turn this flag back off until we can fix this third_party code.

Can use the tryserver master.tryserver.chromium.win:win_optional_gpu_tests_rel to run this target in tryjobs.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/373af458aa9ab8f6f8650da115209c74d14f5dea

commit 373af458aa9ab8f6f8650da115209c74d14f5dea
Author: aleksandar.stojiljkovic <aleksandar.stojiljkovic@intel.com>
Date: Sun Dec 04 16:47:15 2016

Revert "win: /utf-8 for all code"

This reverts commit a53f3c3734ad9ee4322f6a9a60eede7f6b04530f.

Original CL: https://codereview.chromium.org/2543743002

Reason for revert: Compilation issue on master.tryserver.chromium.win:win_optional_gpu_tests_rel

Failing [1] task on the bot:

FAILED: obj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj
ninja -t msvc -e environment.x86 -- E:\b\c\cipd\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj.rsp /c ../../third_party/deqp/src/modules/gles3/performance/es3pBufferDataUploadTests.cpp /Foobj/third_party/angle/src/tests/angle_deqp_libgles3/es3pBufferDataUploadTests.obj /Fd"obj/third_party/angle/src/tests/angle_deqp_libgles3_cc.pdb"
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): error C2220: warning treated as error - no 'object' file generated
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): warning C4828: The file contains a character starting at offset 0x3714f that is illegal in the current source character set (codepage 65001).
e:\b\c\b\win\src\third_party\deqp\src\modules\gles3\performance\es3pbufferdatauploadtests.cpp(5280): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings

[1]
https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/5729/steps/compile%20%28without%20patch%29/logs/stdio

BUG= 454858 ,  637203 ,  671021 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
NOTREECHECKS=true
TBR=scottmg@chromium.org, dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2550973002
Cr-Commit-Position: refs/heads/master@{#436195}

[modify] https://crrev.com/373af458aa9ab8f6f8650da115209c74d14f5dea/build/config/compiler/BUILD.gn

Cc: phaulos@google.com
Does anyone know which character is the problem here? We can certainly upstream fixes to dEQP, just don't see anything on line 5280.

https://cs.chromium.org/chromium/src/third_party/deqp/src/modules/gles3/performance/es3pBufferDataUploadTests.cpp?l=5280
It's at line 6021. (I don't know why that error is so busted.)

It looks like a Mac Ndash, so probably could just be a plain '-'. If you know how to upload/upstream/roll that, that'd be great, thanks!


c:\src\cr\src\third_party\deqp\src\modules\gles3\performance>git show HEAD
commit c7e38727033c858596f7cdfe1951dd8be3127ae9
Author: Scott Graham <scottmg@chromium.org>
Date:   Wed Dec 7 08:45:06 2016 -0800

    Encode es3pBufferDataUploadTests.cpp as utf-8

diff --git a/modules/gles3/performance/es3pBufferDataUploadTests.cpp b/modules/gles3/performance/es3pBufferDataUploadTests.cpp
index bcd79a5..b8de44d 100644
--- a/modules/gles3/performance/es3pBufferDataUploadTests.cpp
+++ b/modules/gles3/performance/es3pBufferDataUploadTests.cpp
@@ -6018,7 +6018,7 @@ static float sumOfRanks (const std::vector<deUint64>& testSamples, const std::ve
 template <typename Comparer>
 static DistributionCompareResult distributionCompare (const std::vector<deUint64>& orderedObservationsA, const std::vector<deUint64>& orderedObservationsB, const Comparer& comparer)
 {
-       // Mann<96>Whitney U test
+       // Mann-Whitney U test

        const int                               n1                      = (int)orderedObservationsA.size();
        const int                               n2                      = (int)orderedObservationsB.size();

Uploaded https://android-review.googlesource.com/#/c/310912/ .

Note that until  issue 643346  gets fixed, rolling dEQP in ANGLE is non-trivial and will break multiple waterfalls (temporarily).
Blockedon: 643346
Oh boy :)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/e735511d47d85f983da61284f8134fa324d6d1b7

commit e735511d47d85f983da61284f8134fa324d6d1b7
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Dec 09 20:55:29 2016

Roll dEQP.

Several months of updates. Does not change the build files - will
mean the GPU.FYI bots temporarily break, and possibly there's some
flakiness on the ANGLE trybots and Optional GPU bots until the
correct suppression set is instated.

BUG= chromium:671021 

Change-Id: I207be11ed37a9173f53a06554880be6ebcaee5fa
Reviewed-on: https://chromium-review.googlesource.com/418405
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/e735511d47d85f983da61284f8134fa324d6d1b7/DEPS.chromium
[modify] https://crrev.com/e735511d47d85f983da61284f8134fa324d6d1b7/DEPS
[modify] https://crrev.com/e735511d47d85f983da61284f8134fa324d6d1b7/src/tests/deqp.gypi

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/e735511d47d85f983da61284f8134fa324d6d1b7

commit e735511d47d85f983da61284f8134fa324d6d1b7
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Dec 09 20:55:29 2016

Roll dEQP.

Several months of updates. Does not change the build files - will
mean the GPU.FYI bots temporarily break, and possibly there's some
flakiness on the ANGLE trybots and Optional GPU bots until the
correct suppression set is instated.

BUG= chromium:671021 

Change-Id: I207be11ed37a9173f53a06554880be6ebcaee5fa
Reviewed-on: https://chromium-review.googlesource.com/418405
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/e735511d47d85f983da61284f8134fa324d6d1b7/DEPS.chromium
[modify] https://crrev.com/e735511d47d85f983da61284f8134fa324d6d1b7/DEPS
[modify] https://crrev.com/e735511d47d85f983da61284f8134fa324d6d1b7/src/tests/deqp.gypi

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/841a6a86754f2375c2d849c37d8786db66bcc25b

commit 841a6a86754f2375c2d849c37d8786db66bcc25b
Author: jmadill <jmadill@chromium.org>
Date: Fri Dec 09 21:04:24 2016

Roll ANGLE 023c2b1..e735511

Forcing this through the CQ to roll dEQP.

https://chromium.googlesource.com/angle/angle.git/+log/023c2b1..e735511

BUG= chromium:671021 
TBR=geofflang@chromium.org
TEST=bots
NOTRY=true
NOPRESUBMIT=true

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2563643004
Cr-Commit-Position: refs/heads/master@{#437649}

[modify] https://crrev.com/841a6a86754f2375c2d849c37d8786db66bcc25b/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/da2f78f9caf4e4f6ee9d3c5765a81d7ea05b7ffe

commit da2f78f9caf4e4f6ee9d3c5765a81d7ea05b7ffe
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Sun Dec 11 00:25:18 2016

Fix compilation after dEQP roll

BUG= chromium:671021 

Change-Id: Iee0e7b1b146b53c6324da8e51d70de42487092b5
Reviewed-on: https://chromium-review.googlesource.com/418510
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/da2f78f9caf4e4f6ee9d3c5765a81d7ea05b7ffe/src/tests/deqp.gypi

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb92a942015508947a60cc81913b4d474168162f

commit fb92a942015508947a60cc81913b4d474168162f
Author: ynovikov <ynovikov@chromium.org>
Date: Mon Dec 12 03:59:02 2016

Roll ANGLE e735511..d023939

https://chromium.googlesource.com/angle/angle.git/+log/e735511..d023939

BUG= chromium:671021 
TBR=jmadill@chromium.org
TEST=bots
NOTRY=true
NOPRESUBMIT=true

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2567923002
Cr-Commit-Position: refs/heads/master@{#437815}

[modify] https://crrev.com/fb92a942015508947a60cc81913b4d474168162f/DEPS

Blockedon: -643346
The ANGLE warning should be fixed now.
Cc: scottmg@chromium.org
Owner: jmad...@chromium.org
Status: Fixed (was: Untriaged)
Thanks Jamie!
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/663994ebf90ac57f5cc56a9639a16e29aee1ff2b

commit 663994ebf90ac57f5cc56a9639a16e29aee1ff2b
Author: scottmg <scottmg@chromium.org>
Date: Tue Dec 13 03:34:05 2016

win: /utf-8 for all code

Previously enabled for chromium_code, can now be turned on everywhere.

BUG= 454858 , 637203 ,  671021 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/a53f3c3734ad9ee4322f6a9a60eede7f6b04530f
Cr-Commit-Position: refs/heads/master@{#436189}

Review-Url: https://codereview.chromium.org/2543743002
Cr-Commit-Position: refs/heads/master@{#438029}

[modify] https://crrev.com/663994ebf90ac57f5cc56a9639a16e29aee1ff2b/build/config/compiler/BUILD.gn

Sign in to add a comment