Convert libhttp2 Tools/Scripts/webkitpy/thirdparty to urllib2 |
||||
Issue descriptionCurrently, web platform test sync tooling (sync-wpt) relies on libhttp2 to handle github OAuth. It's not part of the Python standard libraries, so we need to import it from somewhere. At the moment, it's depot_tools/third_party, which is sort of a hack. Instead, we should just import libhttp2 into Tools/Scripts/webkitpy/thirdparty.
,
Dec 6 2016
I think that the "requests" would also be OK as well. It looks like requests should be currently DEPS'd into //third_party/requests/src right now (https://chromium.googlesource.com/chromium/src/+/master/DEPS#486) but only for android; one possible way of getting it would be to change the DEPS file to also get the library for other platforms. Right now, in general all third party Python libraries for Blink are in webkitpy/thirdparty, so it seems a bit nicer to just add another copy of whichever library we want to use there.
,
Dec 6 2016
requests would probably be fine, but I'd like to confirm that we can't just easily make the standard urllib/urllib2 work first. I suspect the answer is "no, we can't", but I didn't stare at the code to be sure enough. Can you check and report back?
,
Dec 6 2016
It looks like urllib2 is already used in webkitpy: https://cs.chromium.org/search/?q=urllib2+file:third_party/WebKit/Tools/Scripts/webkitpy&sq=package:chromium&type=cs I can transition our code that uses libhttp2 over to urllib2 for consistency if that sounds like a good plan.
,
Dec 6 2016
Sounds like a good plan to me :-)
,
Dec 6 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/330c5f636e80344d7a9c4ef6ade63e1eb297ec7d commit 330c5f636e80344d7a9c4ef6ade63e1eb297ec7d Author: jeffcarp <jeffcarp@chromium.org> Date: Wed Dec 07 04:36:40 2016 Convert WPT export usage of httplib2 to urllib2 BUG= 670987 Review-Url: https://codereview.chromium.org/2557963002 Cr-Commit-Position: refs/heads/master@{#436861} [modify] https://crrev.com/330c5f636e80344d7a9c4ef6ade63e1eb297ec7d/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py [modify] https://crrev.com/330c5f636e80344d7a9c4ef6ade63e1eb297ec7d/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py [modify] https://crrev.com/330c5f636e80344d7a9c4ef6ade63e1eb297ec7d/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py
,
Dec 7 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jeffcarp@chromium.org
, Dec 5 2016