Open app indicator for MD Shelf has usability issue with light backgrounds
Reported by
willg...@gmail.com,
Dec 3 2016
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 9045.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2940.0 Safari/537.36 Platform: 9045.0.0 (Official Build) canary-channel edgar Steps to reproduce the problem: 1. Make sure you're on version 56+ or enable the associated flag 2. Use a light colored wallpaper What is the expected behavior? Can easily see the new dots for open apps on the shelf What went wrong? They can become difficult to view or even invisible with certain colors. Did this work before? N/A Chrome version: 57.0.2940.0 Channel: canary OS Version: 9045.0.0 Flash Version: Shockwave Flash 24.0 r0 The shelf needs some shading or opacity to make them stand out. I really think the opaque shelf seen in the third attachment should become the default behavior.
,
Jan 28 2017
Thanks for the report. Sebastien, what do you think?
,
Feb 10 2017
,
Feb 20 2017
@sgabriel should we outline the indicator or ensure that there's always a dark background behind it somehow?
,
Feb 21 2017
Let's start by adding a black border (#000 16%) around the indicator.
,
Mar 1 2017
@estade this seems like an easy win, could you look into it? sgabriel & bruthig are investigating adaptive coloring for future, but that can be tracked separately.
,
Mar 2 2017
Sebastien: the dot is currently 4 dip across and 2dip from the edge of the screen. Is the 1px border in addition to those 4 dip, or is it included in the 4dip? i.e. will the outer radius of the border circle be 4dip + 1px or 4dip?
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db8636d2cf1ba306fb968a3717daf08437ca0f34 commit db8636d2cf1ba306fb968a3717daf08437ca0f34 Author: estade <estade@chromium.org> Date: Thu Mar 02 04:25:54 2017 Preliminary cleanup of ShelfButton activity/status indicator. This used to be a bar. A lot of the code for it is overly complicated because of that assumption, which is no longer true. This refactors and simplifies for the current visuals (a dot). It also changes the code to draw the circle at the correct scale factor instead of drawing it at a scale factor of 5 then downscaling it, which will be necessary to add the desired 1px border. BUG= 670970 Review-Url: https://codereview.chromium.org/2727073002 Cr-Commit-Position: refs/heads/master@{#454178} [modify] https://crrev.com/db8636d2cf1ba306fb968a3717daf08437ca0f34/ash/common/shelf/shelf_button.cc [modify] https://crrev.com/db8636d2cf1ba306fb968a3717daf08437ca0f34/ash/common/shelf/shelf_button.h
,
Mar 3 2017
it is included in the 4dip.
,
Mar 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7367db27e8ba876cd256abe839deda4078a32d9d commit 7367db27e8ba876cd256abe839deda4078a32d9d Author: estade <estade@chromium.org> Date: Sat Mar 04 01:30:12 2017 Add a 1px border stroke to the shelf button active app indicator. BUG= 670970 Review-Url: https://codereview.chromium.org/2724403005 Cr-Commit-Position: refs/heads/master@{#454741} [modify] https://crrev.com/7367db27e8ba876cd256abe839deda4078a32d9d/ash/common/shelf/shelf_button.cc
,
Mar 4 2017
fixed modulo confirmation from UX that it looks good.
,
Mar 7 2017
Note the CL in #8 made it into M-58 but the CL in #10 did not. IMO this is worth a merge. Re-opening; Evan please request a merge if you agree, otherwise re-target to m-59 and mark as Fixed again.
,
Mar 7 2017
certainly low risk enough to mean that merging doesn't worry me
,
Mar 7 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 7 2017
Just gotten the new indicators today, thanks!
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4f321b71eee416ecea483cdf635706b3e8e0d50 commit c4f321b71eee416ecea483cdf635706b3e8e0d50 Author: Evan Stade <estade@chromium.org> Date: Tue Mar 07 23:40:51 2017 Add a 1px border stroke to the shelf button active app indicator. BUG= 670970 Review-Url: https://codereview.chromium.org/2724403005 Cr-Commit-Position: refs/heads/master@{#454741} (cherry picked from commit 7367db27e8ba876cd256abe839deda4078a32d9d) Review-Url: https://codereview.chromium.org/2736973003 . Cr-Commit-Position: refs/branch-heads/3029@{#52} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/c4f321b71eee416ecea483cdf635706b3e8e0d50/ash/common/shelf/shelf_button.cc
,
Mar 8 2017
,
Mar 21 2017
Comment #6, I've seen the shelf with chrome://flags/#ash-shelf-color enabled and was thinking that it would look really good if the adaptive coloring was expanded to the app indicators too.
,
May 10 2017
9334.63.0, 58.0.3029.97 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by krishna...@chromium.org
, Jan 28 2017Components: UI>Shell>Shelf
Labels: Proj-MaterialDesign-CrOS