New issue
Advanced search Search tips

Issue 670967 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Rename canMakeActivePayment to canMakePayment

Project Member Reported by rouslan@chromium.org, Dec 3 2016

Issue description

^^^
 
Would like to merge https://crrev.com/e3da0af8a1228f17aebefd2f73518654c8b2ab98 ("Rename canMakeActivePayment to canMakePayment") into M-56.

Comment 2 by dimu@chromium.org, Dec 4 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f

commit 6163da6f7a6f1308f2552e08b7a0b7cd003dd42f
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Dec 05 11:09:54 2016

[Merge M-56] Rename canMakeActivePayment to canMakePayment

It was decided to rename canMakeActivePayment to canMakePayment:
https://github.com/w3c/browser-payment-api/pull/316

Note that this feature is still behind a runtime flag, now
named CanMakePayment.

BUG= 670967 

Review-Url: https://codereview.chromium.org/2545523004
Cr-Commit-Position: refs/heads/master@{#436078}
(cherry picked from commit e3da0af8a1228f17aebefd2f73518654c8b2ab98)

Review URL: https://codereview.chromium.org/2552693002 .

Cr-Commit-Position: refs/branch-heads/2924@{#327}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java
[modify] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/android/java_sources.gni
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryNoCardTest.java
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentQueryTest.java
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryNoCardTest.java
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCcCanMakePaymentQueryTest.java
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppCanMakePaymentQueryTest.java
[modify] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/test/data/android/payments/can_make_payment_query.js
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/test/data/android/payments/can_make_payment_query_bobpay.js
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/test/data/android/payments/can_make_payment_query_cc.js
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/test/data/android/payments/payment_request_can_make_payment_query_bobpay_test.html
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/test/data/android/payments/payment_request_can_make_payment_query_cc_test.html
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/chrome/test/data/android/payments/payment_request_can_make_payment_query_test.html
[modify] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/components/payments/payment_request.mojom
[modify] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/third_party/WebKit/Source/modules/BUILD.gn
[rename] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/third_party/WebKit/Source/modules/payments/CanMakePaymentTest.cpp
[modify] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[modify] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/third_party/WebKit/Source/modules/payments/PaymentRequest.idl
[modify] https://crrev.com/6163da6f7a6f1308f2552e08b7a0b7cd003dd42f/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Status: Fixed (was: Started)

Sign in to add a comment