New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 670920 link

Starred by 1 user
Status: Fixed
Owner:
█ jwanda@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.tab.SadTabTest#testSadButtonRevertsBackToReloadAfterSuccessfulLoad" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 3 2016 
"org.chromium.chrome.browser.tab.SadTabTest#testSadButtonRevertsBackToReloadAfterSuccessfulLoad" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyaQsSBUZsYWtlIl5vcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIudGFiLlNhZFRhYlRlc3QjdGVzdFNhZEJ1dHRvblJldmVydHNCYWNrVG9SZWxvYWRBZnRlclN1Y2Nlc3NmdWxMb2FkDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by jbudorick@chromium.org, Dec 5 2016

Owner: jwanda@chromium.org
Status: Assigned (was: Untriaged)
All failing with:

junit.framework.ComparisonFailure: expected:<[Reload]> but was:<[Send Feedback]>
	at org.chromium.chrome.browser.tab.SadTabTest.testSadButtonRevertsBackToReloadAfterSuccessfulLoad(SadTabTest.java:104)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

jwanda, looks like you added this in https://codereview.chromium.org/2534333002. Can you take a look?
Project Member

Comment 2 by chromium...@appspot.gserviceaccount.com, Dec 5 2016 

Detected 4 new flakes for test/step "org.chromium.chrome.browser.tab.SadTabTest#testSadButtonRevertsBackToReloadAfterSuccessfulLoad". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyaQsSBUZsYWtlIl5vcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIudGFiLlNhZFRhYlRlc3QjdGVzdFNhZEJ1dHRvblJldmVydHNCYWNrVG9SZWxvYWRBZnRlclN1Y2Nlc3NmdWxMb2FkDA. This message was posted automatically by the chromium-try-flakes app.

Comment 3 by rogerta@chromium.org, Dec 5 2016

Labels: -Sheriff-Chromium
Removing Sheriff-Chromium label since bug is assigned.

Comment 4 by jwanda@chromium.org, Dec 5 2016

Status: Started (was: Assigned)
Thanks, I'll take a look. Should I revert the cl as I try to find a fix? This is my first break so the protocol is not as clear yet.

Comment 5 by jbudorick@chromium.org, Dec 5 2016 

Reverting or adding @DisabledTest would both be ok.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3b1a6af927de56c1157b5f0edb9558f316ec56f

commit f3b1a6af927de56c1157b5f0edb9558f316ec56f
Author: twellington <twellington@chromium.org>
Date: Tue Dec 06 17:50:00 2016

Disable flaky SadTabTestt#testSadButton* tests

BUG= 670920 
TBR=jwanda@chromium.org,dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2550373003
Cr-Commit-Position: refs/heads/master@{#436634}

[modify] https://crrev.com/f3b1a6af927de56c1157b5f0edb9558f316ec56f/chrome/android/javatests/src/org/chromium/chrome/browser/tab/SadTabTest.java
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4d82dd921d35ea42273aca69d43c290046b42e1

commit a4d82dd921d35ea42273aca69d43c290046b42e1
Author: jwanda <jwanda@chromium.org>
Date: Wed Dec 07 00:23:46 2016

Fixed flaky SadTabReloadButton test

This error was caused by the SadTab getting the Sad Tab button label too
quickly. We needed to wait for the full load to finish before pulling
the button.

BUG= 670920 

Review-Url: https://codereview.chromium.org/2551273002
Cr-Commit-Position: refs/heads/master@{#436772}

[modify] https://crrev.com/a4d82dd921d35ea42273aca69d43c290046b42e1/chrome/android/javatests/src/org/chromium/chrome/browser/tab/SadTabTest.java

Comment 8 by jwanda@chromium.org, Dec 7 2016

Status: Fixed (was: Started)
Should work now.

Comment 9 by jbudorick@chromium.org, Dec 7 2016 

Thanks!
►

Sign in to add a comment