New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670914 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Lazy load lock screen settings in options

Project Member Reported by jdufault@chromium.org, Dec 3 2016

Issue description

Lazy load lock screen settings in options
 

Comment 1 by dbeam@chromium.org, Dec 3 2016

Cc: xiaoyinh@chromium.org dbeam@chromium.org michae...@chromium.org steve...@chromium.org
Labels: -Pri-3 OS-Chrome Pri-2

Comment 2 by dbeam@chromium.org, Dec 3 2016

Components: UI>Settings
Labels: -Type-Bug Performance Type-Bug-Regression
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71f2ed8b6d464a3fca85b7233f5b5995b2aedfd9

commit 71f2ed8b6d464a3fca85b7233f5b5995b2aedfd9
Author: dbeam <dbeam@chromium.org>
Date: Sat Dec 03 03:34:39 2016

Options: lazily load Polymer when quick unlock dialog is triggered

Ruthlessly borrowed from https://codereview.chromium.org/2547273002/ by
Jacob Dufault <jdufault@chromium.org> and simplified :). From that CL's
description:

Locally, this brings first paint time from 1000ms to 500ms.

R=jdufault@chromium.org,xiaoyinh@chromium.org
BUG= 670914 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2529293015
Cr-Commit-Position: refs/heads/master@{#436159}

[modify] https://crrev.com/71f2ed8b6d464a3fca85b7233f5b5995b2aedfd9/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js
[modify] https://crrev.com/71f2ed8b6d464a3fca85b7233f5b5995b2aedfd9/chrome/browser/resources/options/options.html

is this mergeable?
Labels: Merge-Request-56

Comment 6 by dimu@chromium.org, Dec 5 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 5 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86b19c3786427aacb452bf52ea52832e3d98bd70

commit 86b19c3786427aacb452bf52ea52832e3d98bd70
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Dec 05 18:22:49 2016

Options: lazily load Polymer when quick unlock dialog is triggered

Ruthlessly borrowed from https://codereview.chromium.org/2547273002/ by
Jacob Dufault <jdufault@chromium.org> and simplified :). From that CL's
description:

Locally, this brings first paint time from 1000ms to 500ms.

R=jdufault@chromium.org,xiaoyinh@chromium.org
BUG= 670914 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2529293015
Cr-Commit-Position: refs/heads/master@{#436159}
(cherry picked from commit 71f2ed8b6d464a3fca85b7233f5b5995b2aedfd9)

Review URL: https://codereview.chromium.org/2550203002 .

Cr-Commit-Position: refs/branch-heads/2924@{#337}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/86b19c3786427aacb452bf52ea52832e3d98bd70/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js
[modify] https://crrev.com/86b19c3786427aacb452bf52ea52832e3d98bd70/chrome/browser/resources/options/options.html

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment