New issue
Advanced search Search tips

Issue 670908 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 578344



Sign in to add a comment

After the "big rename" WTF::passed and base::Passed (and possibly other such pairs) will be ambiguous without namespace qualifier

Project Member Reported by lukasza@chromium.org, Dec 3 2016

Issue description

After automated rename WTF::passed function will be ambiguous wrt base::Passed.

I think the best and safest thing to do will be to namespace-qualify WTF::passed everywhere.
 
Summary: After automated rename WTF::passed and WTF::wrapUnique functions will be ambiguous with functions from base:: namespace (was: After automated rename WTF::passed function will be ambiguous wrt base::Passed.)
This also affects WTF::wrapUnique
Agree.
And possibly also affects other things like makeUnique (although so far I haven't run into an actual build failure caused by this).
Makes sense to me too.

(I'm a little curious why WTF has traditionally decided to put all of its names into the global namespace: I suppose the other solution here is to write ::passed, but I agree that WTF::passed is the right solution)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d858647530db2c22e1267e443034d23f2e602d9

commit 9d858647530db2c22e1267e443034d23f2e602d9
Author: lukasza <lukasza@chromium.org>
Date: Thu Dec 08 21:52:12 2016

Explicit WTF:: qualifier for passed, unretained, wrapUnique and makeUnique.

The functions listed in the title of the CL description exist both in
WTF:: and in base:: namespaces and differ only by the case (uppercase vs
lowercase) of the first character in their identifiers.  This will lead
to compile errors after renaming the WTF functions to follow Chromium
style (PascalCaseFunctionNames) because of |using| statements that today
enable the WTF functions to be used without namespace qualification -
such usage will be ambiguous after the rename.  Example:

    ../../third_party/WebKit/Source/platform/WaitableEvent.cpp:17:11:
    error: call to 'WrapUnique' is ambiguous
      impl_ = WrapUnique(new base::WaitableEvent(
              ^~~~~~~~~~
    ../../base/memory/ptr_util.h:17:20:
    note: candidate function [with T = base::WaitableEvent]
    std::unique_ptr<T> WrapUnique(T* ptr) {
                       ^
    ../../third_party/WebKit/Source/wtf/PtrUtil.h:16:20:
    note: candidate function [with T = base::WaitableEvent]
    std::unique_ptr<T> WrapUnique(T* ptr) {
                       ^
This CL
1) adds WTF:: namespace qualifier to all calls to the affected WTF
   functions
2) removes |using| statements that import the affected WTF functions
   into the global namespace

The second change means that failure to namespace-qualify a call will be
a compile error (e.g. error: use of undeclared identifier 'WrapUnique')
when the argument doesn't come from base or WTF namespace (preventing
reoccurence of the problem in these cases).  When the argument comes
from base or WTF namespace, then ADL will pick the function from the
corresponding namespace.

The Google C++ Style Guide allows using type aliases (including |using
other_namespace::Foo|), although it also says to prefer placing
nonmember functions in a namespace and to use completely global
functions rarely.  The guide also explicitly says "You may not use a
using-directive to make all names from a namespace available" - this is
not what WTF is doing here, but I guess one could argue that all the
individual |using WTF::foo| declarations taken together are not that
different from just doing |using namespace WTF|.  FWIW, I don't see
(grepping for 'using.*base') any |using| statement in a header file
under //base that would pull a name from base:: into the global
namespace (except using base::PathService which is there for legacy
reasons).  References:
- https://google.github.io/styleguide/cppguide.html#Aliases
- https://google.github.io/styleguide/cppguide.html#Namespaces
- https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_and_Global_Functions

This CL was generated in a fairly mechanical way:
- Run the following under third_party/WebKit/Source for (passed,
  unretained, wrapUnique):
  $ ag '\bpassed\b\(' -l | xargs -n 1 \
      sed -e 's/\([^:]\)\bpassed\b(/\1WTF::passed(/g' -i
- Run the following under third_party/WebKit/Source (for makeUnique):
  $ ag '\bmakeUnique' -l | xargs -n 1 \
      sed -e 's/\([^:]\)\bmakeUnique<\(.*\)>(/\1WTF::makeUnique<\2>(/g' -i
- Manually remove |using WTF::foo| declarations.
- Manually fixup function definitions (where no WTF:: qualifier should
  be used).
- git cl format
- Manually fix formatting inside comments.
- Do a self-review.

Affected functions:
- third_party/WebKit/Source/wtf/PtrUtil.h:
  - WTF::wrapUnique / base::WrapUnique
  - WTF::makeUnique / base::MakeUnique
- third_party/WebKit/Source/wtf/Functional.h:
  - WTF::passed / base::Passed
  - WTF::unretained / base::Unretained

Note that there are a lot more using statements under WTF that can
potentially conflict with things from other namespaces.  This CL tweaks
only names that are known to cause compile failures after the automatic
rename from blinkStyleFunctions into ChromiumStyleFunctions.  In
particular, the following things are not tweaked by this CL:
- wtf/ASCIICType.h (e.g. WTF::isASCIILower function)
- wtf/AutoReset.h (WTF::AutoReset class)
- wtf/text/Base64.h (e.g. WTF::base64Encode function)
- wtf/Time.h (e.g. WTF::TimeDelta class)

BUG= 670908 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2547053003
Cr-Commit-Position: refs/heads/master@{#437358}

[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/Microtask.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/V0CustomElementBinding.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/InterpolableValue.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/LengthUnitsChecker.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/PrimitiveInterpolation.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/TypedInterpolationValue.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/UnderlyingLengthChecker.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/css/CSSAnimationData.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/animation/css/CSSTransitionData.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/css/CSSPropertySourceData.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/css/SelectorFilter.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/css/resolver/StyleResolverStats.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/dom/AXObjectCache.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/dom/CompositorProxiedPropertySet.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/dom/ContextFeatures.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/dom/ExecutionContextTask.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/dom/IncrementLoadEventDelayCount.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/dom/ScriptedAnimationControllerTest.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/dom/SelectorQuery.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/events/EventFactory.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/events/ScopedEventQueue.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/fetch/MockFetchContext.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/fileapi/FileReaderLoader.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/frame/Settings.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/ClassList.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/HTMLAreaElement.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/HTMLStyleElement.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/TextControlElementTest.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/forms/InputType.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/parser/HTMLMetaCharsetParser.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/parser/HTMLToken.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/parser/HTMLTokenizer.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/parser/PreloadRequest.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/parser/TextResourceDecoder.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/FloatingObjects.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/ImageQualityController.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/LayoutCounter.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/line/RootInlineBox.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/ng/ng_units.cc
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/shapes/Shape.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp
[modify] https://crrev.com/9d858647530db2c22e1267e443034d23f2e602d9/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp
[modify] h
Summary: After the "big rename" WTF::passed and base::Passed (and possibly other such pairs) will be ambiguous without namespace qualifier (was: After automated rename WTF::passed and WTF::wrapUnique functions will be ambiguous with functions from base:: namespace)
Known issues have been fixed, but let's keep this bug opened for a while, to see if we bump into other trouble-causing functions named similarily in base:: and WTF::.

Comment 7 by dcheng@chromium.org, Dec 19 2016

Status: Fixed (was: Started)
Marking as fixed to make issue tracking easier. We can re-open if we find other instances.

Sign in to add a comment