New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670898 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Left Chrome team
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Fix statistics for InstantAppsApiDuration

Project Member Reported by mariakho...@chromium.org, Dec 2 2016

Issue description

Make sure that only instant apps API time is recorded and not anything else. Currently there's a path where if an exception is thrown, we could be recording an incorrect value.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/c9f760a8c4620ed7b13031ccd233f0fc95cbe6e2

commit c9f760a8c4620ed7b13031ccd233f0fc95cbe6e2
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Mon Dec 05 22:29:11 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba6c108d584629567b1bf45515b20ba90d6dee8d

commit ba6c108d584629567b1bf45515b20ba90d6dee8d
Author: mariakhomenko <mariakhomenko@chromium.org>
Date: Tue Dec 06 20:48:35 2016

Instant Apps: Change the name of the metric.

The metric is now recorded differently, update to a new name.

BUG= 670898 

Review-Url: https://codereview.chromium.org/2551073003
Cr-Commit-Position: refs/heads/master@{#436711}

[modify] https://crrev.com/ba6c108d584629567b1bf45515b20ba90d6dee8d/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
[modify] https://crrev.com/ba6c108d584629567b1bf45515b20ba90d6dee8d/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-56

Comment 4 by dimu@chromium.org, Dec 6 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9595405d19bf5e40d885f753afe7ed47f6081b52

commit 9595405d19bf5e40d885f753afe7ed47f6081b52
Author: mariakhomenko <mariakhomenko@chromium.org>
Date: Wed Dec 07 19:41:29 2016

Instant Apps: Split latency recordings into two.

Separately record the latency for Instant Apps API calls that result in
an application being found and those that do not.

BUG= 670898 

Review-Url: https://codereview.chromium.org/2555693003
Cr-Commit-Position: refs/heads/master@{#437034}

[modify] https://crrev.com/9595405d19bf5e40d885f753afe7ed47f6081b52/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
[modify] https://crrev.com/9595405d19bf5e40d885f753afe7ed47f6081b52/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/ca7a6ef99c6fee55a091d3173e921326e01bfa1a

commit ca7a6ef99c6fee55a091d3173e921326e01bfa1a
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Wed Dec 07 00:18:25 2016

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/ca7a6ef99c6fee55a091d3173e921326e01bfa1a

commit ca7a6ef99c6fee55a091d3173e921326e01bfa1a
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Wed Dec 07 00:18:25 2016

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 8 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/322d736026e79562d8df3df210283b2f12503ce2

commit 322d736026e79562d8df3df210283b2f12503ce2
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Mon Dec 05 22:29:11 2016

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2aeb160a4b36d36d2f771a616bf8da9da21f4cc8

commit 2aeb160a4b36d36d2f771a616bf8da9da21f4cc8
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Thu Dec 08 18:31:29 2016

Instant Apps: Change the name of the metric.

The metric is now recorded differently, update to a new name.

BUG= 670898 

Review-Url: https://codereview.chromium.org/2551073003
Cr-Commit-Position: refs/heads/master@{#436711}
(cherry picked from commit ba6c108d584629567b1bf45515b20ba90d6dee8d)

Review URL: https://codereview.chromium.org/2550413006 .

Cr-Commit-Position: refs/branch-heads/2924@{#412}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/2aeb160a4b36d36d2f771a616bf8da9da21f4cc8/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
[modify] https://crrev.com/2aeb160a4b36d36d2f771a616bf8da9da21f4cc8/tools/metrics/histograms/histograms.xml

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca33327934e6b9fdff331bfa2b1768b1420616b2

commit ca33327934e6b9fdff331bfa2b1768b1420616b2
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Thu Dec 08 19:37:56 2016

Instant Apps: Split latency recordings into two.

Separately record the latency for Instant Apps API calls that result in
an application being found and those that do not.

BUG= 670898 

Review-Url: https://codereview.chromium.org/2555693003
Cr-Commit-Position: refs/heads/master@{#437034}
(cherry picked from commit 9595405d19bf5e40d885f753afe7ed47f6081b52)

Review URL: https://codereview.chromium.org/2561863002 .

Cr-Commit-Position: refs/branch-heads/2924@{#414}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/ca33327934e6b9fdff331bfa2b1768b1420616b2/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
[modify] https://crrev.com/ca33327934e6b9fdff331bfa2b1768b1420616b2/tools/metrics/histograms/histograms.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/dad4ad1a699355716512456a8170f300b22f01e9

commit dad4ad1a699355716512456a8170f300b22f01e9
Author: Maria Khomenko <mariakhomenko@chromium.org>
Date: Wed Dec 07 00:18:25 2016

Status: Fixed (was: Assigned)

Sign in to add a comment