New issue
Advanced search Search tips

Issue 670897 link

Starred by 1 user
Status: Fixed
Owner:
xingliu@chromium.org
Closed: Dec 2016
Cc:
dtrainor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Tab switcher stack disappears after pinch tabs to the top

Project Member Reported by xingliu@chromium.org, Dec 2 2016 
To reproduce:

Add 3 tabs in tab switcher, pinch and scroll to the top. The whole stacks goes away.

Cause: Some of the number is set to Nan due to division to 0, which cause the Y position of the stack to be NaN too.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/531c3255a45abfa9b6a8a621c76b88c1f5b21a73

commit 531c3255a45abfa9b6a8a621c76b88c1f5b21a73
Author: xingliu <xingliu@chromium.org>
Date: Mon Dec 05 23:44:47 2016

The whole tab stack disappears when the user pinch all tabs together
and scroll to the top of the screen when we have multiple tabs.

This is caused by Y position of the stack sets to NaN, where there is
a division to 0 in the code.

BUG= 670897 

Review-Url: https://codereview.chromium.org/2551653002
Cr-Commit-Position: refs/heads/master@{#436457}

[modify] https://crrev.com/531c3255a45abfa9b6a8a621c76b88c1f5b21a73/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java

Comment 2 by xingliu@chromium.org, Dec 7 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment