New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 670890 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Permission warnings for settings overrides are badly formatted

Project Member Reported by rdevlin....@chromium.org, Dec 2 2016

Issue description

See screenshot.  We shouldn't be saying an extension can change your homepage to msn.com/<incomprehensible>.

Webstore Page: https://chrome.google.com/webstore/detail/msn-homepage/ibflkkanbidceofpmolhpijgminhbmnm
 
bad permission warnings.png
25.7 KB View Download

Comment 2 by jawag@chromium.org, Dec 7 2016

Feedback from UI review: We should use the hostname, not the full path.
I commented in an email thread, but per Enamel's URL display standards should also show the scheme unless it's guaranteed to be HTTPS.

I strongly recommend FormatUrlForSecurityDisplay() if that looks good.
Cc: rdevlin....@chromium.org
Owner: karandeepb@chromium.org
karandeepb@ has joined the extensions team, and is looking for some good first bugs.
Labels: -OS-Linux -OS-Chrome
Settings Override API is only enabled on Windows(Stable) and Mac(Trunk) currently.
Status: Started (was: Assigned)
Also, following up from #3, I think that it's more important to be consistent with the rest of the extension prompt permissions (which omit scheme).  I'd be fine with having a discussion of moving them all over, but for now, I'd like to stay consistent.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fdd4984f81bebc66dc2c36e4336f60328802ff9

commit 0fdd4984f81bebc66dc2c36e4336f60328802ff9
Author: karandeepb <karandeepb@chromium.org>
Date: Wed Feb 08 00:04:47 2017

Extensions: Only display host name for the overridden home and start-up pages.

Currently, the full path is shown for the home and start-up settings override
permissions. This makes the dialog UI look badly formatted and
incomprehensible. This CL changes the dialogs to only show the host name for
the overridden home and start-up pages. Existing tests are also modified.

BUG= 670890 
TEST=On Mac(trunk only) or Windows, open
https://chrome.google.com/webstore/detail/msn-homepage/ibflkkanbidceofpmolhpijgminhbmnm.
Click on Add to Chrome. Ensure only the host name is shown (without the www
prefix) for the new home and start-up page, on the dialog which shows up.

Review-Url: https://codereview.chromium.org/2676393002
Cr-Commit-Position: refs/heads/master@{#448805}

[modify] https://crrev.com/0fdd4984f81bebc66dc2c36e4336f60328802ff9/chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc
[modify] https://crrev.com/0fdd4984f81bebc66dc2c36e4336f60328802ff9/chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment