PathBuilderKeyRolloverTest.TestMultipleRootMatchesOnlyOneWorks depends on specific order of reading elements from an unordered_multimap |
||
Issue descriptionTestMultipleRootMatchesOnlyOneWorks expects the path builder to try paths in a specific order, specifically, it expects it to first find a bad path, and then find a good path. If the trust store returns the anchor for the good path first, it will never try the bad path, and the test will fail. Tests use in-memory trust store which is backed by unordered_multimap, which is unordered, i.e. the order in which the anchors are returned are platform-specific. So depending on libc you're compiling with and the phase of the moon, the test may break, which it did when I tried merging new Chromium changes into proto-quic today.
,
Dec 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec676214d6c88ed2bdc156f5f0f66b57b6e6b813 commit ec676214d6c88ed2bdc156f5f0f66b57b6e6b813 Author: mattm <mattm@chromium.org> Date: Sat Dec 03 01:22:05 2016 Fix PathBuilderKeyRolloverTest.TestMultipleRootMatchesOnlyOneWorks unordered_multimap ordering dependency. BUG= 670889 Review-Url: https://codereview.chromium.org/2550893002 Cr-Commit-Position: refs/heads/master@{#436121} [modify] https://crrev.com/ec676214d6c88ed2bdc156f5f0f66b57b6e6b813/net/cert/internal/path_builder_unittest.cc
,
Dec 3 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by mattm@chromium.org
, Dec 3 2016