New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 670886 link

Starred by 1 user
Status: Verified
Owner:
philipchen@chromium.org
Closed: Dec 2016
Cc:
█ sha...@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ec: charge_manager: Cleanup asserts / docs

Project Member Reported by sha...@chromium.org, Dec 2 2016 
- Remove all runtime asserts.
- Document function param / return values in header file.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/11ddfabb7229f1d00f9c5d5ca94595dbab904682

commit 11ddfabb7229f1d00f9c5d5ca94595dbab904682
Author: philipchen <philipchen@google.com>
Date: Sun Dec 04 00:28:43 2016

charge_manager: cleanup and document

Remove some runtime assert to reduce code size.
Improve the documentation.

BUG= chromium:670886 
BRANCH=none
TEST=make buildall -j

Change-Id: I60bd787fad94779cd978aefa26e0581fb5f6ebef
Reviewed-on: https://chromium-review.googlesource.com/416392
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>

[modify] https://crrev.com/11ddfabb7229f1d00f9c5d5ca94595dbab904682/include/charge_manager.h
[modify] https://crrev.com/11ddfabb7229f1d00f9c5d5ca94595dbab904682/common/charge_manager.c

Comment 2 by sha...@chromium.org, Dec 8 2016

Cc: -philipchen@chromium.org
Owner: philipchen@chromium.org
Status: Verified (was: Untriaged)
►

Sign in to add a comment