DevTools: relative links are not linkified in console errors |
||
Issue description
Links inside of the red text in an error are not always linkified correctly. See screenshot for example.
Another example:
console.error('Error\nat (../script.js:1:0)')
Similar to crbug.com/535463
,
Dec 3 2016
Currently we aren't doing any relative path resolution, so linkifying them to script locations in Sources isn't possible without a new relative path resolution feature. What we can do is make these relative paths at lease linkify as external links. tryFormatAsError() tries to extract links, but gives up completely on candidates that it cannot parse as a ParsedURL. It should be possible to make it more lenient for this case.
,
Dec 5 2016
For reference, there was a similar bug that ended up as WontFix: crbug.com/535463 . Let's make sure to test that URLs with valid URLs inside them don't trigger long regex execution time.
,
Dec 14 2017
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ea427a89579d09eb02e8d5226dc71779a90acbe commit 3ea427a89579d09eb02e8d5226dc71779a90acbe Author: Erik Luo <luoe@chromium.org> Date: Thu Dec 14 01:29:51 2017 DevTools: linkify relative links in error traces Screenshot: https://imgur.com/a/HvEpQ Bug: 670883 Change-Id: Ife7c85f35e4ead089c7251931db033f1afa1f9dd Reviewed-on: https://chromium-review.googlesource.com/821595 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523971} [add] https://crrev.com/3ea427a89579d09eb02e8d5226dc71779a90acbe/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-linkify-relative-links-expected.txt [add] https://crrev.com/3ea427a89579d09eb02e8d5226dc71779a90acbe/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-linkify-relative-links.js [modify] https://crrev.com/3ea427a89579d09eb02e8d5226dc71779a90acbe/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-linkify-stack-in-errors-expected.txt [modify] https://crrev.com/3ea427a89579d09eb02e8d5226dc71779a90acbe/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt [modify] https://crrev.com/3ea427a89579d09eb02e8d5226dc71779a90acbe/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js |
||
►
Sign in to add a comment |
||
Comment 1 by l...@chromium.org
, Dec 2 2016