New issue
Advanced search Search tips

Issue 670877 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CIPD package display under "More Details" has unclear hierarchy

Project Member Reported by iannu...@google.com, Dec 2 2016

Issue description

See https://chromium-swarm.appspot.com/task?id=32da4a51463e8510&refresh=10&request_detail=true

The mixing of folder and package information leads to unclear UI. E.g. the old UI would show (note the spacing differentiation between folders and packages):

./
  infra/tools/luci/kitchen/${platform}:git_revision:d520d9c3bc253f70b499e4b8fe10f6d839361285
recipes-py/
  infra/recipes-py:git_revision:6e11fcc25f244f962bf750349a805bb3261977ff
third_party/coverage/
  infra/coverage-py/cp27/${platform}:version:4.1

The new UI shows:

third_party/coverage/
Requested:infra/coverage-py/cp27/${platform}:version:4.1
Actual:infra/coverage-py/cp27/linux-amd64:7408052818903acdccfd1b24a196e8cbaa661de1
recipes-py/
Requested:infra/recipes-py:git_revision:6e11fcc25f244f962bf750349a805bb3261977ff
Actual:infra/recipes-py:f043ee7c781779c50fbfb9d18a14c42fae3132bb
./
Requested:infra/tools/luci/kitchen/${platform}:git_revision:d520d9c3bc253f70b499e4b8fe10f6d839361285
Actual:infra/tools/luci/kitchen/linux-amd64:dd9133f79f41ef5c15f51d2d01beb25ca362ead5

This is unfortunately difficult to read/work with :/
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/7accffd689653e501f311a82d5dd15c61b3cd123

commit 7accffd689653e501f311a82d5dd15c61b3cd123
Author: kjlubick <kjlubick@google.com>
Date: Tue Dec 06 14:34:29 2016

Fix swarming Task Page layout

1. Fix the flexing such that the two columns are properly displayed on
smaller screens.

2. Fix CIPD layouts to be more user friendly.

BUG= 670873 ,  670877 ,  670872 

Review-Url: https://codereview.chromium.org/2554533002

[modify] https://crrev.com/7accffd689653e501f311a82d5dd15c61b3cd123/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/7accffd689653e501f311a82d5dd15c61b3cd123/appengine/swarming/ui/res/imp/taskpage/task-page.html

Status: Fixed (was: Started)
This is live on chromium-swarm.

Sign in to add a comment