New window width on a fresh profile is pretty narrow |
||||
Issue descriptionI just got a new 15" touchy MacBook Pro. It has a 2880x1800 display. There appears to be a 7/6 scale factor, so it appears to userland as 3360x2100, but this is 2x, so the 1x equivalent would be 1680x1050. I installed and opened Chrome. The new browser window took up less than half of the screen’s width. javascript:alert(window.innerWidth) says 807. This is crazy! It’s only using 48% of the width of the screen! Does anyone browse with portrait windows instead of landscape anymore? Does the web even work well at a width of 807 anymore? I don’t think that this has been revisited since the very first days of Chrome on Mac. What do we do on other platforms?
,
Dec 7 2016
Looks like these values come from TabWindowController: https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm?q=tab_window_controller&sq=package:chromium&l=70 -> shrike for decision, Untriage or reassign if you think we should have different values
,
Jul 25 2017
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/255a96883ec1cb264854b04c31cd430a0942a6b7 commit 255a96883ec1cb264854b04c31cd430a0942a6b7 Author: Jayson Adams <shrike@chromium.org> Date: Wed Jul 26 23:28:38 2017 [Mac] Use a better default browser window width. The default window width on the Mac for a new profile is uncomfortably narrow. It appears that the width was being chosen with an eye toward allowing the user to place two browser windows side-by-side. This cl disables the side-by-side window width setting on macOS, and sets the macOS default window width to 1200pt, which is a good choice for modern screens (Safari chooses 1300pt+). R=mark@chromium.org, sky@chromium.org Bug: 670876 Change-Id: I574b0382be70069ad509190011969d9cae054f9a Reviewed-on: https://chromium-review.googlesource.com/584863 Commit-Queue: Jayson Adams <shrike@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#489796} [modify] https://crrev.com/255a96883ec1cb264854b04c31cd430a0942a6b7/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm [modify] https://crrev.com/255a96883ec1cb264854b04c31cd430a0942a6b7/chrome/browser/ui/window_sizer/window_sizer.cc [modify] https://crrev.com/255a96883ec1cb264854b04c31cd430a0942a6b7/chrome/browser/ui/window_sizer/window_sizer.h [modify] https://crrev.com/255a96883ec1cb264854b04c31cd430a0942a6b7/chrome/browser/ui/window_sizer/window_sizer_aura.cc [modify] https://crrev.com/255a96883ec1cb264854b04c31cd430a0942a6b7/chrome/browser/ui/window_sizer/window_sizer_mac.mm [modify] https://crrev.com/255a96883ec1cb264854b04c31cd430a0942a6b7/chrome/browser/ui/window_sizer/window_sizer_unittest.cc
,
Jul 26 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mark@chromium.org
, Dec 2 20168.1 MB
8.1 MB View Download