Sync same src/ revision for builders+testers in chromium.webrtc.fyi |
|||
Issue descriptionAs a continuation of bug 669818 , where most of the problems with the bots in chromium.webrtc.fyi were resolved, this bug tracks fixing the last remaining problem: Both builders and testers sync Chromium src@HEAD. This means that a builder can sync revision X, do a build and then ship it over to the tester to run the tests. Since the tester also syncs HEAD, it's possible that HEAD has incremented to X+N, which will be what is presented in the tester's build properties (got_cr_revision etc). The blamelists are showing only WebRTC changes (since these bots poll and trigger builds on src/third_party/webrtc) but in case there's a suspected Chromium change that triggers a perf regression, it can lead to major confusion if one is looking at got_cr_revision for the tester (parent_got_cr_revision will always be correct - the builder's synced revision of src/ but ideally also got_cr_revision should be correct). As this is corner case, I'm setting it as P3 for now. I will document the limitation in the perf sheriff instructions and point to this bug. Location for the change to be made is: https://cs.chromium.org/chromium/tools/depot_tools/recipe_modules/gclient/config.py?rcl=0&l=403
,
Jun 30 2017
I got stuck on refactoring requests in the code review so I couldn't finish. It would be great if someone could complete this complicated work. Edward I'm leaving this to you to either finish or mentor someone in how it works and then land. The CL can probably be split up if that makes things easier.
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/e50b04d7a969c41e319ec84c34065ffab9ce5eb0 commit e50b04d7a969c41e319ec84c34065ffab9ce5eb0 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu Jul 06 15:14:47 2017 WebRTC: Generate correct Chromium blamelist links for chromium.webrtc.fyi testers Spun off from https://chromium-review.googlesource.com/c/449834/ BUG=697875, 670856 Change-Id: I97b4387182165ffa3a247b1f2153ed54da0fcc11 Reviewed-on: https://chromium-review.googlesource.com/558987 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/e50b04d7a969c41e319ec84c34065ffab9ce5eb0/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py [modify] https://crrev.com/e50b04d7a969c41e319ec84c34065ffab9ce5eb0/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py [add] https://crrev.com/e50b04d7a969c41e319ec84c34065ffab9ce5eb0/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_tester.json [modify] https://crrev.com/e50b04d7a969c41e319ec84c34065ffab9ce5eb0/scripts/slave/README.recipes.md [add] https://crrev.com/e50b04d7a969c41e319ec84c34065ffab9ce5eb0/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_fyi_tester.json [modify] https://crrev.com/e50b04d7a969c41e319ec84c34065ffab9ce5eb0/scripts/slave/recipe_modules/chromium_tests/steps.py [delete] https://crrev.com/75ece9a31b3510196872f354ee1fb257928b588d/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/basic.json [modify] https://crrev.com/e50b04d7a969c41e319ec84c34065ffab9ce5eb0/scripts/slave/recipe_modules/chromium_tests/api.py [modify] https://crrev.com/e50b04d7a969c41e319ec84c34065ffab9ce5eb0/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.py
,
Jul 26 2017
Can this be closed? Has the result been verified?
,
Jul 27 2017
Yes, I believe so. |
|||
►
Sign in to add a comment |
|||
Comment 1 by kjellander@chromium.org
, Mar 27 2017