New issue
Advanced search Search tips

Issue 670855 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Select-All Should Be Disabled in Context Menu if Omnibox Text is Already Fully Selected

Project Member Reported by mpear...@chromium.org, Dec 2 2016

Issue description


Split from
https://bugs.chromium.org/p/chromium/issues/detail?id=223522#c11

This is a problem on Linux.

It does not reproduce on Mac.  (The "Select All" option is not even in the context menu in this case.)

Tagging as ChromeOS and Windows because the problem likely exists there as well.

 
Owner: simonh...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51afc830d2cb4e3c15efb393ab8c8bb689159d20

commit 51afc830d2cb4e3c15efb393ab8c8bb689159d20
Author: simonhong <simonhong@chromium.org>
Date: Thu Apr 20 21:10:55 2017

[Textfield] Consider select all status for select all context menu

Disable select all context menu when text is all selected, too.

BUG= 670855 
R=pkasting@chromium.org
TEST=views_unittests --gtest_filter=TextfieldTest.ContextMenuDisplayTest

Review-Url: https://codereview.chromium.org/2829823002
Cr-Commit-Position: refs/heads/master@{#466132}

[modify] https://crrev.com/51afc830d2cb4e3c15efb393ab8c8bb689159d20/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/51afc830d2cb4e3c15efb393ab8c8bb689159d20/ui/views/controls/textfield/textfield_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment